printing::Metafile: Simplify OS_MACOSX-specific code path

printing/printed_document_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/printed_document.h"
 
-#import <ApplicationServices/ApplicationServices.h>
-#import <CoreFoundation/CoreFoundation.h>
+#include <ApplicationServices/ApplicationServices.h>

[Lei Zhang, 2017/04/08 01:24:25]

BTW, I'm clueless about #import vs #include, so maybe ask someone with more Mac
experience if you are not certain.

[hal.canary, 2017/04/11 19:07:27]

Acknowledged.

+#include <CoreFoundation/CoreFoundation.h>
 
 #include "base/logging.h"
 #include "printing/page_number.h"
+#include "printing/pdf_metafile_cg_mac.h"
 #include "printing/printed_page.h"
 
 namespace printing {
 
 void PrintedDocument::RenderPrintedPage(
     const PrintedPage& page,
     skia::NativeDrawingContext context) const {
 #ifndef NDEBUG
   {
     // Make sure the page is from our list.
     base::AutoLock lock(lock_);
     DCHECK(&page == mutable_.pages_.find(page.page_number() - 1)->second.get());
   }
 #endif
 
   DCHECK(context);
 
   const PageSetup& page_setup(immutable_.settings_.page_setup_device_units());
   gfx::Rect content_area;
   page.GetCenteredPageContentRect(page_setup.physical_size(), &content_area);
 
   const MetafilePlayer* metafile = page.metafile();
+
   // Each Metafile is a one-page PDF, and pages use 1-based indexing.
   const int page_number = 1;
-  struct Metafile::MacRenderPageParams params;
+  struct PdfMetafileCg::RenderPageParams params;

[Lei Zhang, 2017/04/08 01:24:25]

I think you can omit the struct keyword.

[hal.canary, 2017/04/11 19:07:27]

Done.

   params.autorotate = true;
-  metafile->RenderPage(page_number, context, content_area.ToCGRect(), params);
+  std::vector<char> buffer;
+  if (metafile->GetDataAsVector(&buffer)) {
+    PdfMetafileCg::RenderPage(buffer.data(), buffer.size(), page_number,
+                              context, content_area.ToCGRect(), params);
+  }
 }
 
 }  // namespace printing