printing::Metafile: Simplify OS_MACOSX-specific code path

printing/pdf_metafile_cg_mac_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/pdf_metafile_cg_mac.h"
 
-#import <ApplicationServices/ApplicationServices.h>
+#include <ApplicationServices/ApplicationServices.h>
+#include <CoreFoundation/CoreFoundation.h>
 #include <stdint.h>
 
 #include <string>
 #include <vector>
 
+#include "base/mac/scoped_cftyperef.h"
+#include "printing/pdf_metafile_skia.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/geometry/rect.h"
 
+using base::ScopedCFTypeRef;
+
 namespace printing {
 
 TEST(PdfMetafileCgTest, Pdf) {
-  // Test in-renderer constructor.
-  PdfMetafileCg pdf;
+  // Create test PDF.
+  PdfMetafileSkia pdf(PDF_SKIA_DOCUMENT_TYPE);
   EXPECT_TRUE(pdf.Init());
   EXPECT_TRUE(pdf.context() != NULL);
 
   // Render page 1.
   gfx::Rect rect_1(10, 10, 520, 700);
   gfx::Size size_1(540, 720);
   pdf.StartPage(size_1, rect_1, 1.25);
   pdf.FinishPage();
 
   // Render page 2.
   gfx::Rect rect_2(10, 10, 520, 700);
   gfx::Size size_2(720, 540);
   pdf.StartPage(size_2, rect_2, 2.0);
   pdf.FinishPage();
 
   pdf.FinishDocument();
 
   // Check data size.
   uint32_t size = pdf.GetDataSize();
   EXPECT_GT(size, 0U);

[Lei Zhang, 2017/04/08 01:24:24]

This should be an ASSERT_GT(), BTW.

[hal.canary, 2017/04/11 19:07:27]

I reverted changes to this file.   No longer applicable.

 
   // Get resulting data.
   std::vector<char> buffer(size, 0);
-  pdf.GetData(&buffer.front(), size);
-
-  // Test browser-side constructor.
-  PdfMetafileCg pdf2;
-  EXPECT_TRUE(pdf2.InitFromData(&buffer.front(), size));
-
-  // Get the first 4 characters from pdf2.
-  std::vector<char> buffer2(4, 0);
-  pdf2.GetData(&buffer2.front(), 4);
+  pdf.GetData(buffer.data(), size);
 
   // Test that the header begins with "%PDF".
-  std::string header(&buffer2.front(), 4);
+  std::string header(buffer.data(), 4);
   EXPECT_EQ(0U, header.find("%PDF", 0));
 
-  // Test that the PDF is correctly reconstructed.
-  EXPECT_EQ(2U, pdf2.GetPageCount());
-  gfx::Size page_size = pdf2.GetPageBounds(1).size();
-  EXPECT_EQ(540, page_size.width());
-  EXPECT_EQ(720, page_size.height());
-  page_size = pdf2.GetPageBounds(2).size();
-  EXPECT_EQ(720, page_size.width());
-  EXPECT_EQ(540, page_size.height());
+  base::ScopedCFTypeRef<CFMutableDataRef> pdf_data(
+      CFDataCreateMutable(kCFAllocatorDefault, 0));
+  EXPECT_TRUE(pdf_data.get() != nullptr);
+  ScopedCFTypeRef<CGDataConsumerRef> pdf_consumer(
+      CGDataConsumerCreateWithCFData(pdf_data));
+  EXPECT_TRUE(pdf_consumer.get() != nullptr);
+  base::ScopedCFTypeRef<CGContextRef> context(
+      CGPDFContextCreate(pdf_consumer, nullptr, nullptr));
+  EXPECT_TRUE(context.get() != nullptr);
+
+  PdfMetafileCg::RenderPageParams params;
+  EXPECT_TRUE(PdfMetafileCg::RenderPage(buffer.data(), size, 1, context.get(),
+                                        CGRectMake(0, 0, 540, 720), params));
 }
 
 }  // namespace printing