Use web-app manifest format for Android payment apps.

chrome/android/junit/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderTest.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments;
 
 import android.content.Intent;
 import android.content.pm.ActivityInfo;
 import android.content.pm.ApplicationInfo;
 import android.content.pm.PackageInfo;
 import android.content.pm.ResolveInfo;
 import android.content.pm.ServiceInfo;
 import android.content.pm.Signature;
 import android.content.res.Resources;
 import android.os.Bundle;
 
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.ArgumentMatcher;
 import org.mockito.ArgumentMatchers;
 import org.mockito.Mockito;
 import org.robolectric.RobolectricTestRunner;
 import org.robolectric.annotation.Config;
 
 import org.chromium.chrome.browser.payments.PaymentAppFactory.PaymentAppCreatedCallback;
 import org.chromium.components.payments.PaymentManifestDownloader;
 import org.chromium.components.payments.PaymentManifestParser;
 import org.chromium.content_public.browser.WebContents;
-import org.chromium.payments.mojom.PaymentManifestSection;
+import org.chromium.payments.mojom.WebAppManifestSection;
 
 import java.net.URI;
+import java.net.URISyntaxException;
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
 
 /** Tests for the native Android payment app finder. */
 @RunWith(RobolectricTestRunner.class)
 @Config(sdk = 21, manifest = Config.NONE)
 public class AndroidPaymentAppFinderTest {
     private static final IntentArgumentMatcher sPayIntentArgumentMatcher =
             new IntentArgumentMatcher(new Intent("org.chromium.intent.action.PAY"));
 
     public AndroidPaymentAppFinderTest() {}
 
     /**
      * Argument matcher that matches Intents using |filterEquals| method.
      */
     private static class IntentArgumentMatcher implements ArgumentMatcher<Intent> {
-
         private final Intent mIntent;
 
         public IntentArgumentMatcher(Intent intent) {
             mIntent = intent;
         }
 
         @Override
         public boolean matches(Intent other) {
             return mIntent.filterEquals(other);
         }
@@ skipping 208 matching lines @@
                              ArgumentMatchers.eq(bobPay.activityInfo.applicationInfo)))
                 .thenReturn(resouces);
 
         List<ResolveInfo> services = new ArrayList<>();
         ResolveInfo isBobPayReadyToPay = new ResolveInfo();
         isBobPayReadyToPay.serviceInfo = new ServiceInfo();
         isBobPayReadyToPay.serviceInfo.packageName = "com.bobpay.app";
         isBobPayReadyToPay.serviceInfo.name = "com.bobpay.app.IsReadyToWebPay";
         services.add(isBobPayReadyToPay);
         Intent isReadyToPayIntent = new Intent(AndroidPaymentAppFinder.ACTION_IS_READY_TO_PAY);
-        Mockito.when(packageManagerDelegate.getServicesThatCanRespondToIntent(
+        Mockito
+                .when(packageManagerDelegate.getServicesThatCanRespondToIntent(

[gogerald1, 2017/04/07 19:36:16]

Mockito.when could be in single line

[please use gerrit instead, 2017/04/08 18:54:48]

Done.

                         ArgumentMatchers.argThat(new IntentArgumentMatcher(isReadyToPayIntent))))
                 .thenReturn(services);
 
         PackageInfo bobPayPackageInfo = new PackageInfo();
         bobPayPackageInfo.versionCode = 10;
         bobPayPackageInfo.signatures = new Signature[1];
         bobPayPackageInfo.signatures[0] = new Signature("01020304050607080900");
         Mockito.when(packageManagerDelegate.getPackageInfoWithSignatures("com.bobpay.app"))
                 .thenReturn(bobPayPackageInfo);
 
         PaymentManifestDownloader downloader = new PaymentManifestDownloader(null) {
             @Override
-            public void download(URI uri, ManifestDownloadCallback callback) {
-                callback.onManifestDownloadSuccess("some content here");
+            public void downloadPaymentMethodManifest(URI uri, ManifestDownloadCallback callback) {
+                callback.onPaymentMethodManifestDownloadSuccess("some content here");
+            }
+
+            @Override
+            public void downloadWebAppManifest(URI uri, ManifestDownloadCallback callback) {
+                callback.onWebAppManifestDownloadSuccess("some content here");
             }
         };
 
         PaymentManifestParser parser = new PaymentManifestParser() {
             @Override
-            public void parse(String content, ManifestParseCallback callback) {
-                PaymentManifestSection[] manifest = new PaymentManifestSection[1];
-                manifest[0] = new PaymentManifestSection();
-                manifest[0].packageName = "com.bobpay.app";
-                manifest[0].version = 10;
-                // SHA256("01020304050607080900"):
-                manifest[0].sha256CertFingerprints = new byte[][] {{(byte) 0x9A, (byte) 0x89,
-                        (byte) 0xC6, (byte) 0x8C, (byte) 0x4C, (byte) 0x5E, (byte) 0x28,
-                        (byte) 0xB8, (byte) 0xC4, (byte) 0xA5, (byte) 0x56, (byte) 0x76,
-                        (byte) 0x73, (byte) 0xD4, (byte) 0x62, (byte) 0xFF, (byte) 0xF5,
-                        (byte) 0x15, (byte) 0xDB, (byte) 0x46, (byte) 0x11, (byte) 0x6F,
-                        (byte) 0x99, (byte) 0x00, (byte) 0x62, (byte) 0x4D, (byte) 0x09,
-                        (byte) 0xC4, (byte) 0x74, (byte) 0xF5, (byte) 0x93, (byte) 0xFB}};
-                callback.onManifestParseSuccess(manifest);
+            public void parsePaymentMethodManifest(String content, ManifestParseCallback callback) {
+                try {
+                    callback.onPaymentMethodManifestParseSuccess(
+                            new URI[] {new URI("https://bobpay.com/app.json")});
+                } catch (URISyntaxException e) {
+                    assert false;
+                }
             }
 
             @Override
+            public void parseWebAppManifest(String content, ManifestParseCallback callback) {
+                WebAppManifestSection[] manifest = new WebAppManifestSection[1];
+                manifest[0] = new WebAppManifestSection();
+                manifest[0].id = "com.bobpay.app";
+                manifest[0].minVersion = 10;
+                // SHA256("01020304050607080900"):
+                manifest[0].fingerprints = new byte[][] {{(byte) 0x9A, (byte) 0x89, (byte) 0xC6,
+                        (byte) 0x8C, (byte) 0x4C, (byte) 0x5E, (byte) 0x28, (byte) 0xB8,
+                        (byte) 0xC4, (byte) 0xA5, (byte) 0x56, (byte) 0x76, (byte) 0x73,
+                        (byte) 0xD4, (byte) 0x62, (byte) 0xFF, (byte) 0xF5, (byte) 0x15,
+                        (byte) 0xDB, (byte) 0x46, (byte) 0x11, (byte) 0x6F, (byte) 0x99,
+                        (byte) 0x00, (byte) 0x62, (byte) 0x4D, (byte) 0x09, (byte) 0xC4,
+                        (byte) 0x74, (byte) 0xF5, (byte) 0x93, (byte) 0xFB}};
+                callback.onWebAppManifestParseSuccess(manifest);
+            }
+
+            @Override
             public void startUtilityProcess() {}
 
             @Override
             public void stopUtilityProcess() {}
         };
 
         Set<String> methodNames = new HashSet<>();
         methodNames.add("https://bobpay.com");
         PaymentAppCreatedCallback callback = Mockito.mock(PaymentAppCreatedCallback.class);
 
@@ skipping 22 matching lines @@
                 String expectedAppIdentifier) {
             return new Matches(expectedAppIdentifier);
         }
 
         @Override
         public boolean matches(PaymentApp app) {
             return app.getAppIdentifier().equals(mExpectedAppIdentifier);
         }
     }
 }