Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: cc/surfaces/surface_manager_unittest.cc

Issue 2802023002: Remove SurfaceFactory And SurfaceFactoryClient (Closed)
Patch Set: Rebase SurfaceSynchronizationTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_manager.cc ('k') | cc/surfaces/surface_resource_holder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_manager_unittest.cc
diff --git a/cc/surfaces/surface_manager_unittest.cc b/cc/surfaces/surface_manager_unittest.cc
index 53fe6ed9c677abd7328c9f5294e37ac3b725fb0f..07047fdbb8d9fa132407cd32709885fcb18f78d3 100644
--- a/cc/surfaces/surface_manager_unittest.cc
+++ b/cc/surfaces/surface_manager_unittest.cc
@@ -6,9 +6,7 @@
#include "cc/scheduler/begin_frame_source.h"
#include "cc/surfaces/frame_sink_manager_client.h"
-#include "cc/surfaces/surface_factory_client.h"
#include "cc/surfaces/surface_manager.h"
-#include "cc/surfaces/surface_resource_holder_client.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace cc {
@@ -184,7 +182,7 @@ TEST_F(SurfaceManagerTest, MultipleDisplays) {
// This test verifies that a BeginFrameSource path to the root from a
// FrameSinkId is preserved even if that FrameSinkId has no children
-// and does not have a corresponding SurfaceFactoryClient.
+// and does not have a corresponding FrameSinkManagerClient.
TEST_F(SurfaceManagerTest, ParentWithoutClientRetained) {
StubBeginFrameSource root_source;
@@ -201,7 +199,7 @@ TEST_F(SurfaceManagerTest, ParentWithoutClientRetained) {
EXPECT_EQ(&root_source, root.source());
// Set up initial hierarchy: root -> A -> B.
- // Note that A does not have a SurfaceFactoryClient.
+ // Note that A does not have a FrameSinkManagerClient.
manager_.RegisterFrameSinkHierarchy(kFrameSinkIdRoot, kFrameSinkIdA);
manager_.RegisterFrameSinkHierarchy(kFrameSinkIdA, kFrameSinkIdB);
// The root's BeginFrameSource should propagate to B.
@@ -237,7 +235,7 @@ TEST_F(SurfaceManagerTest,
FakeFrameSinkManagerClient client_c(kFrameSinkIdC, &manager_);
// Set up initial hierarchy: root -> A -> B.
- // Note that A does not have a SurfaceFactoryClient.
+ // Note that A does not have a FrameSinkManagerClient.
manager_.RegisterFrameSinkHierarchy(kFrameSinkIdRoot, kFrameSinkIdA);
manager_.RegisterFrameSinkHierarchy(kFrameSinkIdA, kFrameSinkIdB);
// The root does not yet have a BeginFrameSource so client B should not have
@@ -260,7 +258,7 @@ TEST_F(SurfaceManagerTest,
}
// In practice, registering and unregistering both parent/child relationships
-// and SurfaceFactoryClients can happen in any ordering with respect to
+// and FrameSinkManagerClients can happen in any ordering with respect to
// each other. These following tests verify that all the data structures
// are properly set up and cleaned up under the four permutations of orderings
// of this nesting.
« no previous file with comments | « cc/surfaces/surface_manager.cc ('k') | cc/surfaces/surface_resource_holder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698