Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: cc/surfaces/frame_sink_manager.h

Issue 2802023002: Remove SurfaceFactory And SurfaceFactoryClient (Closed)
Patch Set: Rebase SurfaceSynchronizationTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink.h ('k') | cc/surfaces/frame_sink_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/frame_sink_manager.h
diff --git a/cc/surfaces/frame_sink_manager.h b/cc/surfaces/frame_sink_manager.h
index b48642f2bdf1c84934fb904f2d123b629476620e..0d54a8e3d8f002356887f22bc78f6e512d041401 100644
--- a/cc/surfaces/frame_sink_manager.h
+++ b/cc/surfaces/frame_sink_manager.h
@@ -21,7 +21,7 @@ class BeginFrameSource;
class FrameSinkManagerClient;
namespace test {
-class CompositorFrameSinkSupportTest;
+class SurfaceSynchronizationTest;
}
class CC_SURFACES_EXPORT FrameSinkManager {
@@ -35,8 +35,8 @@ class CC_SURFACES_EXPORT FrameSinkManager {
// possibly because a renderer process has crashed.
void InvalidateFrameSinkId(const FrameSinkId& frame_sink_id);
- // SurfaceFactoryClient, hierarchy, and BeginFrameSource can be registered
- // and unregistered in any order with respect to each other.
+ // CompositorFrameSinkSupport, hierarchy, and BeginFrameSource can be
+ // registered and unregistered in any order with respect to each other.
//
// This happens in practice, e.g. the relationship to between ui::Compositor /
// DelegatedFrameHost is known before ui::Compositor has a surface/client).
@@ -73,7 +73,7 @@ class CC_SURFACES_EXPORT FrameSinkManager {
}
private:
- friend class test::CompositorFrameSinkSupportTest;
+ friend class test::SurfaceSynchronizationTest;
void RecursivelyAttachBeginFrameSource(const FrameSinkId& frame_sink_id,
BeginFrameSource* source);
@@ -90,8 +90,9 @@ class CC_SURFACES_EXPORT FrameSinkManager {
// considered satisfied.
std::unordered_set<FrameSinkId, FrameSinkIdHash> valid_frame_sink_ids_;
- // Begin frame source routing. Both BeginFrameSource and SurfaceFactoryClient
- // pointers guaranteed alive by callers until unregistered.
+ // Begin frame source routing. Both BeginFrameSource and
+ // CompositorFrameSinkSupport pointers guaranteed alive by callers until
+ // unregistered.
struct FrameSinkSourceMapping {
FrameSinkSourceMapping();
FrameSinkSourceMapping(const FrameSinkSourceMapping& other);
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink.h ('k') | cc/surfaces/frame_sink_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698