Remove SurfaceFactory And SurfaceFactoryClient

cc/surfaces/surface_resource_holder.cc

Index: cc/surfaces/surface_resource_holder.cc
diff --git a/cc/surfaces/surface_resource_holder.cc b/cc/surfaces/surface_resource_holder.cc
index dff955cbde28f294bf2c3cb0c5410366339e4b48..86e6dd481f348ca4b4053fb844e5402af30290e2 100644
--- a/cc/surfaces/surface_resource_holder.cc
+++ b/cc/surfaces/surface_resource_holder.cc
@@ -6,17 +6,14 @@
 
 #include "cc/surfaces/surface_resource_holder_client.h"
 namespace cc {
-
 SurfaceResourceHolder::SurfaceResourceHolder(
     SurfaceResourceHolderClient* client)
     : client_(client) {}
 
-SurfaceResourceHolder::~SurfaceResourceHolder() {
-}
+SurfaceResourceHolder::~SurfaceResourceHolder() {}

[Fady Samuel, 2017/04/28 12:30:30]

SurfaceResourceHolder::~SurfaceResourceHolder() = default;

[Alex Z., 2017/04/28 12:40:33]

Done.

 
 SurfaceResourceHolder::ResourceRefs::ResourceRefs()
-    : refs_received_from_child(0), refs_holding_resource_alive(0) {
-}
+    : refs_received_from_child(0), refs_holding_resource_alive(0) {}
 
 void SurfaceResourceHolder::Reset() {
   resource_id_info_map_.clear();
@@ -24,9 +21,7 @@ void SurfaceResourceHolder::Reset() {
 
 void SurfaceResourceHolder::ReceiveFromChild(
     const TransferableResourceArray& resources) {
-  for (TransferableResourceArray::const_iterator it = resources.begin();
-       it != resources.end();
-       ++it) {
+  for (auto it = resources.begin(); it != resources.end(); ++it) {

[Fady Samuel, 2017/04/28 12:30:30]

This should work.

for (auto& resource : resources) {
  .. 
}

[Alex Z., 2017/04/28 12:40:33]

That can't be done either. "Non-const lvalue cannot bind to a 
temporary."

     ResourceRefs& ref = resource_id_info_map_[it->id];
     ref.refs_holding_resource_alive++;
     ref.refs_received_from_child++;