Remove SurfaceFactory And SurfaceFactoryClient

cc/test/mock_compositor_frame_sink_support_client.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cc/test/mock_compositor_frame_sink_support_client.h"
+
+namespace cc {
+namespace test {
+
+MockCompositorFrameSinkSupportClient::MockCompositorFrameSinkSupportClient(
+    bool create_surface_during_eviction) {

[danakj, 2017/05/03 16:08:40]

this is never true right? remove it?

[Alex Z., 2017/05/03 18:07:37]

It is true in CompositorFrameSinkSupportTest.AddDuringEviction.

[danakj, 2017/05/05 16:04:19]

I see. Can you move the ON_CALL stuff to that test then and remove it from this
class? Then support_ can go too, and this is just a mock interface here.

+  ON_CALL(*this, ReclaimResources(_))
+      .WillByDefault(Invoke(
+          this,
+          &MockCompositorFrameSinkSupportClient::ReclaimResourcesInternal));
+  ON_CALL(*this, DidReceiveCompositorFrameAck(_))
+      .WillByDefault(Invoke(
+          this,
+          create_surface_during_eviction
+              ? &MockCompositorFrameSinkSupportClient::CreateSurfaceDrawCallback
+              : &MockCompositorFrameSinkSupportClient::
+                    ReclaimResourcesInternal));
+}
+
+MockCompositorFrameSinkSupportClient::~MockCompositorFrameSinkSupportClient() =
+    default;
+}  // namespace test

[danakj, 2017/05/03 16:08:39]

whitespace above this

[Alex Z., 2017/05/03 18:07:37]

Done.

+}  // namespace cc