Remove SurfaceFactory And SurfaceFactoryClient

cc/surfaces/surface_resource_holder.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/surface_resource_holder.h"
 
 #include "cc/surfaces/surface_resource_holder_client.h"
 namespace cc {
-
 SurfaceResourceHolder::SurfaceResourceHolder(
     SurfaceResourceHolderClient* client)
     : client_(client) {}
 
-SurfaceResourceHolder::~SurfaceResourceHolder() {
-}
+SurfaceResourceHolder::~SurfaceResourceHolder() {}

[Fady Samuel, 2017/04/28 12:30:30]

SurfaceResourceHolder::~SurfaceResourceHolder() = default;

[Alex Z., 2017/04/28 12:40:33]

Done.

 
 SurfaceResourceHolder::ResourceRefs::ResourceRefs()
-    : refs_received_from_child(0), refs_holding_resource_alive(0) {
-}
+    : refs_received_from_child(0), refs_holding_resource_alive(0) {}
 
 void SurfaceResourceHolder::Reset() {
   resource_id_info_map_.clear();
 }
 
 void SurfaceResourceHolder::ReceiveFromChild(
     const TransferableResourceArray& resources) {
-  for (TransferableResourceArray::const_iterator it = resources.begin();
-       it != resources.end();
-       ++it) {
+  for (auto it = resources.begin(); it != resources.end(); ++it) {

[Fady Samuel, 2017/04/28 12:30:30]

This should work.

for (auto& resource : resources) {
  .. 
}

[Alex Z., 2017/04/28 12:40:33]

That can't be done either. "Non-const lvalue cannot bind to a 
temporary."

     ResourceRefs& ref = resource_id_info_map_[it->id];
     ref.refs_holding_resource_alive++;
     ref.refs_received_from_child++;
   }
 }
 
 void SurfaceResourceHolder::RefResources(
     const TransferableResourceArray& resources) {
   for (TransferableResourceArray::const_iterator it = resources.begin();
        it != resources.end();
@@ skipping 27 matching lines @@
       returned.count = ref.refs_received_from_child;
       resources_available_to_return.push_back(returned);
       resource_id_info_map_.erase(count_it);
     }
   }
 
   client_->ReturnResources(resources_available_to_return);
 }
 
 }  // namespace cc