Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 52f9a6bfe21b4cb28d55fca4f5483e2b27f2ead8..0793169a1df9f40d30bb26722b845b803ace7842 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -15229,6 +15229,26 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Enterprise.RetrieveDeviceLocalAccountPolicyResponse" |
|
emaxx
2017/04/21 00:01:53
nit: Maybe group all three histograms under a comm
igorcov
2017/04/21 11:36:22
Done.
|
| + enum="RetrievePolicyResponseType"> |
| + <owner>igorcov@chromium.org</owner> |
|
Daniel Erat
2017/04/20 21:06:39
please list additional owners for these if possibl
igorcov
2017/04/21 11:36:22
Done.
|
| + <summary> |
| + The response obtained to retrieve device local account policy request. |
|
Daniel Erat
2017/04/20 21:06:39
make all of these start with "On Chrome OS, " to m
igorcov
2017/04/21 11:36:22
Done.
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Enterprise.RetrieveDevicePolicyResponse" |
| + enum="RetrievePolicyResponseType"> |
| + <owner>igorcov@chromium.org</owner> |
| + <summary>The response obtained to retrieve device policy request.</summary> |
| +</histogram> |
| + |
| +<histogram name="Enterprise.RetrieveUserPolicyResponse" |
| + enum="RetrievePolicyResponseType"> |
| + <owner>igorcov@chromium.org</owner> |
| + <summary>The response obtained to retrieve user policy request.</summary> |
| +</histogram> |
| + |
| <histogram name="Enterprise.SystemLogPIILeak" enum="SystemLogPIIType"> |
| <obsolete> |
| Deprecated and removed from code as of 01/2016. |
| @@ -110384,6 +110404,13 @@ from previous Chrome versions. |
| <int value="1" label="Cached StyleSheetContents was reused"/> |
| </enum> |
| +<enum name="RetrievePolicyResponseType" type="int"> |
|
emaxx
2017/04/21 00:01:53
nit: Many <enum>'s have a corresponding <summary>,
emaxx
2017/04/21 00:01:53
nit: Please prepend the enum name with the word "E
igorcov
2017/04/21 11:36:22
Done.
igorcov
2017/04/21 11:36:22
Done.
|
| + <int value="0" label="Success"/> |
| + <int value="1" label="Retrieve request issued before session started"/> |
| + <int value="2" label="Failed to retrieve policy data in session manager"/> |
| + <int value="3" label="Other type of error on retrieve policy request"/> |
| +</enum> |
| + |
| <enum name="RevalidationPolicy" type="int"> |
| <int value="0" label="Use"/> |
| <int value="1" label="Revalidate"/> |