chrome/browser/chromeos/settings/session_manager_operation.h - Issue 2801993002: Abandon user sign in when policy is retrieved before session started

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/session_manager_operation.h

Issue 2801993002: Abandon user sign in when policy is retrieved before session started (Closed)

Patch Set: Nit Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/settings/session_manager_operation.h

diff --git a/chrome/browser/chromeos/settings/session_manager_operation.h b/chrome/browser/chromeos/settings/session_manager_operation.h

index 3b67b31d107b70fba69c87f2c27e4d8af379c218..a7e6c340fbcb044e4492eb6b48179d92b85248cf 100644

--- a/chrome/browser/chromeos/settings/session_manager_operation.h

+++ b/chrome/browser/chromeos/settings/session_manager_operation.h

@@ -111,7 +111,10 @@ class SessionManagerOperation {

void BlockingRetrieveDeviceSettings();

// Validates device settings after retrieval from session_manager.

- void ValidateDeviceSettings(const std::string& policy_blob);

+ void ValidateDeviceSettings(

+ const std::string& policy_blob,

+ const chromeos::SessionManagerClient::RetrievePolicyResponseType&

emaxx 2017/04/18 15:03:17 nit: "chromeos::" is unnecessary here

emaxx 2017/04/18 15:03:17 nit: #include "chromeos/dbus/session_manager_clien

igorcov 2017/04/20 14:52:29 Done.

+ response_type);

// Extracts status and device settings from the validator and reports them.

void ReportValidatorStatus(policy::DeviceCloudPolicyValidator* validator);