Abandon user sign in when policy is retrieved before session started

chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_USER_CLOUD_POLICY_STORE_CHROMEOS_H_
 #define CHROME_BROWSER_CHROMEOS_POLICY_USER_CLOUD_POLICY_STORE_CHROMEOS_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 55 matching lines @@
   // Completion handler for policy validation on the Store() path.
   // Starts a store operation if the validation succeeded.
   void OnPolicyToStoreValidated(UserCloudPolicyValidator* validator);
 
   // Called back from SessionManagerClient for policy store operations.
   void OnPolicyStored(bool success);
 
   // Called back from SessionManagerClient for policy load operations.
   void OnPolicyRetrieved(const std::string& policy_blob);
 
+  void OnPolicyRetrievedWithError(const std::string& error_name,

[Daniel Erat, 2017/04/10 18:59:26]

please add a comment documenting what calls this and what it does.

consider renaming these to e.g. OnPolicyRetrievedSuccess and
OnPolicyRetrievedError

[igorcov, 2017/04/18 10:23:18]

Done.

+                                  const std::string& error_message);
+
   // Starts validation of the loaded |policy| before installing it.
   void ValidateRetrievedPolicy(
       std::unique_ptr<enterprise_management::PolicyFetchResponse> policy);
 
   // Completion handler for policy validation on the Load() path. Installs the
   // policy and publishes it if validation succeeded.
   void OnRetrievedPolicyValidated(UserCloudPolicyValidator* validator);
 
   // Invokes |callback| after reloading |policy_key_|.
   void ReloadPolicyKey(const base::Closure& callback);
@@ skipping 34 matching lines @@
   base::FilePath cached_policy_key_path_;
 
   base::WeakPtrFactory<UserCloudPolicyStoreChromeOS> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(UserCloudPolicyStoreChromeOS);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_CHROMEOS_POLICY_USER_CLOUD_POLICY_STORE_CHROMEOS_H_