[DevTools] Remove SDK.SDKObject

third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 43 matching lines @@
    * @param {!SDK.Target} target
    */
   targetRemoved(target) {
     Bindings.NetworkProject.forTarget(target)._dispose();
   }
 };
 
 /**
  * @unrestricted
  */
-Bindings.NetworkProject = class extends SDK.SDKObject {
+Bindings.NetworkProject = class {
   /**
    * @param {!SDK.Target} target
    * @param {!Workspace.Workspace} workspace
    * @param {?SDK.ResourceTreeModel} resourceTreeModel
    */
   constructor(target, workspace, resourceTreeModel) {
-    super(target);
+    this._target = target;

[pfeldman, 2017/04/07 18:36:03]

I don't think it makes sense removing SDKObject without removing this._target.
You are not changing anything with your change. Inheriting from Object is free
(it is lazy) and you only increase the number of lines here.

What might make sense is removing this_target all over the place.

     this._workspace = workspace;
     /** @type {!Map<string, !Bindings.ContentProviderBasedProject>} */
     this._workspaceProjects = new Map();
     this._resourceTreeModel = resourceTreeModel;
     target[Bindings.NetworkProject._networkProjectSymbol] = this;
 
     this._eventListeners = [];
 
     if (resourceTreeModel) {
       this._eventListeners.push(
@@ skipping 78 matching lines @@
     var mimeType = Common.ResourceType.mimeFromURL(uiSourceCode.url());
     return mimeType || uiSourceCode.contentType().canonicalMimeType();
   }
 
   /**
    * @param {string} frameId
    * @param {boolean} isContentScripts
    * @return {!Bindings.ContentProviderBasedProject}
    */
   _workspaceProject(frameId, isContentScripts) {
-    var projectId = Bindings.NetworkProject.projectId(this.target(), frameId, isContentScripts);
+    var projectId = Bindings.NetworkProject.projectId(this._target, frameId, isContentScripts);
     var projectType = isContentScripts ? Workspace.projectTypes.ContentScripts : Workspace.projectTypes.Network;
 
     var project = this._workspaceProjects.get(projectId);
     if (project)
       return project;
 
     project = new Bindings.ContentProviderBasedProject(
         this._workspace, projectId, projectType, '', false /* isServiceProject */);
-    project[Bindings.NetworkProject._targetSymbol] = this.target();
+    project[Bindings.NetworkProject._targetSymbol] = this._target;
     project[Bindings.NetworkProject._frameSymbol] =
         frameId && this._resourceTreeModel ? this._resourceTreeModel.frameForId(frameId) : null;
     this._workspaceProjects.set(projectId, project);
     return project;
   }
 
   /**
    * @param {!Common.ContentProvider} contentProvider
    * @param {string} frameId
    * @param {boolean} isContentScript
@@ skipping 16 matching lines @@
     this._removeFileForURL(url, frameId, isContentScript);
   }
 
   /**
    * @param {string} frameId
    * @param {string} url
    * @param {boolean} isContentScript
    */
   _removeFileForURL(url, frameId, isContentScript) {
     var project =
-        this._workspaceProjects.get(Bindings.NetworkProject.projectId(this.target(), frameId, isContentScript));
+        this._workspaceProjects.get(Bindings.NetworkProject.projectId(this._target, frameId, isContentScript));
     if (!project)
       return;
     project.removeFile(url);
   }
 
   _populate() {
     /**
      * @param {!SDK.ResourceTreeFrame} frame
      * @this {Bindings.NetworkProject}
      */
@@ skipping 94 matching lines @@
     // Ignore non-images and non-fonts.
     if (resourceType === Common.resourceTypes.Image && resource.mimeType && !resource.mimeType.startsWith('image'))
       return;
     if (resourceType === Common.resourceTypes.Font && resource.mimeType && !resource.mimeType.includes('font'))
       return;
     if ((resourceType === Common.resourceTypes.Image || resourceType === Common.resourceTypes.Font) &&
         resource.contentURL().startsWith('data:'))
       return;
 
     // Never load document twice.
-    var projectId = Bindings.NetworkProject.projectId(this.target(), resource.frameId, false);
+    var projectId = Bindings.NetworkProject.projectId(this._target, resource.frameId, false);
     var project = this._workspaceProjects.get(projectId);
     if (project && project.uiSourceCodeForURL(resource.url))
       return;
 
     var uiSourceCode = this._createFile(resource, resource.frameId, false);
     uiSourceCode[Bindings.NetworkProject._resourceSymbol] = resource;
     this._addUISourceCodeWithProvider(uiSourceCode, resource, this._resourceMetadata(resource));
   }
 
   /**
@@ skipping 25 matching lines @@
   }
 
   /**
    * @param {!Common.Event} event
    */
   _mainFrameNavigated(event) {
     this._reset();
   }
 
   _suspendStateChanged() {
-    if (this.target().targetManager().allTargetsSuspended())
+    if (this._target.targetManager().allTargetsSuspended())
       this._reset();
     else
       this._populate();
   }
 
   /**
    * @param {!Common.ContentProvider} contentProvider
    * @param {string} frameId
    * @param {boolean} isContentScript
    * @return {!Workspace.UISourceCode}
    */
   _createFile(contentProvider, frameId, isContentScript) {
     var url = contentProvider.contentURL();
     var project = this._workspaceProject(frameId, isContentScript);
     var uiSourceCode = project.createUISourceCode(url, contentProvider.contentType());
-    uiSourceCode[Bindings.NetworkProject._targetSymbol] = this.target();
+    uiSourceCode[Bindings.NetworkProject._targetSymbol] = this._target;
     return uiSourceCode;
   }
 
   /**
    * @param {?SDK.Resource} resource
    * @return {?Workspace.UISourceCodeMetadata}
    */
   _resourceMetadata(resource) {
     if (!resource || (typeof resource.contentSize() !== 'number' && !resource.lastModified()))
       return null;
     return new Workspace.UISourceCodeMetadata(resource.lastModified(), resource.contentSize());
   }
 
   _dispose() {
     this._reset();
     Common.EventTarget.removeEventListeners(this._eventListeners);
-    delete this.target()[Bindings.NetworkProject._networkProjectSymbol];
+    delete this._target[Bindings.NetworkProject._networkProjectSymbol];
   }
 
   _reset() {
     for (var project of this._workspaceProjects.values())
       project.removeProject();
     this._workspaceProjects.clear();
   }
 
   /**
    * @param {!Workspace.Workspace} workspace
@@ skipping 20 matching lines @@
         Bindings.NetworkProject.projectId(header.cssModel().target(), header.frameId, false), url);
   }
 };
 
 Bindings.NetworkProject._networkProjectSymbol = Symbol('networkProject');
 Bindings.NetworkProject._resourceSymbol = Symbol('resource');
 Bindings.NetworkProject._scriptSymbol = Symbol('script');
 Bindings.NetworkProject._styleSheetSymbol = Symbol('styleSheet');
 Bindings.NetworkProject._targetSymbol = Symbol('target');
 Bindings.NetworkProject._frameSymbol = Symbol('frame');