third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp - Issue 2801893003: Revert of Changed CSSParserContext argument from * to & for null safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

Issue 2801893003: Revert of Changed CSSParserContext argument from * to & for null safety. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetAnchor.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOpacity.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

index cc9baa97d6682fb9cf9c909034b7a26750cf6e16..76f80cc9e8b7db4310b96202c2b4b7def454ed9f 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

@@ -13,16 +13,16 @@

const CSSValue* CSSPropertyAPIOffsetPosition::parseSingleValue(

CSSParserTokenRange& range,

- const CSSParserContext& context) {

+ const CSSParserContext* context) {

CSSValueID id = range.peek().id();

if (id == CSSValueAuto)

return CSSPropertyParserHelpers::consumeIdent(range);

CSSValue* value = CSSPropertyParserHelpers::consumePosition(

- range, context.mode(), CSSPropertyParserHelpers::UnitlessQuirk::Forbid);

+ range, context->mode(), CSSPropertyParserHelpers::UnitlessQuirk::Forbid);

// Count when we receive a valid position other than 'auto'.

if (value && value->isValuePair())

- context.count(UseCounter::CSSOffsetInEffect);

+ context->count(UseCounter::CSSOffsetInEffect);

return value;

}