Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp

Issue 2801893003: Revert of Changed CSSParserContext argument from * to & for null safety. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/css/properties/CSSPropertyAPIRotate.h" 5 #include "core/css/properties/CSSPropertyAPIRotate.h"
6 6
7 #include "core/CSSValueKeywords.h" 7 #include "core/CSSValueKeywords.h"
8 #include "core/css/CSSValueList.h" 8 #include "core/css/CSSValueList.h"
9 #include "core/css/parser/CSSPropertyParserHelpers.h" 9 #include "core/css/parser/CSSPropertyParserHelpers.h"
10 #include "platform/RuntimeEnabledFeatures.h" 10 #include "platform/RuntimeEnabledFeatures.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 const CSSValue* CSSPropertyAPIRotate::parseSingleValue( 14 const CSSValue* CSSPropertyAPIRotate::parseSingleValue(
15 CSSParserTokenRange& range, 15 CSSParserTokenRange& range,
16 const CSSParserContext& context) { 16 const CSSParserContext* context) {
17 DCHECK(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled()); 17 DCHECK(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled());
18 18
19 CSSValueID id = range.peek().id(); 19 CSSValueID id = range.peek().id();
20 if (id == CSSValueNone) 20 if (id == CSSValueNone)
21 return CSSPropertyParserHelpers::consumeIdent(range); 21 return CSSPropertyParserHelpers::consumeIdent(range);
22 22
23 CSSValueList* list = CSSValueList::createSpaceSeparated(); 23 CSSValueList* list = CSSValueList::createSpaceSeparated();
24 24
25 for (unsigned i = 0; i < 3; i++) { // 3 dimensions of rotation 25 for (unsigned i = 0; i < 3; i++) { // 3 dimensions of rotation
26 CSSValue* dimension = 26 CSSValue* dimension =
27 CSSPropertyParserHelpers::consumeNumber(range, ValueRangeAll); 27 CSSPropertyParserHelpers::consumeNumber(range, ValueRangeAll);
28 if (!dimension) { 28 if (!dimension) {
29 if (i == 0) 29 if (i == 0)
30 break; 30 break;
31 return nullptr; 31 return nullptr;
32 } 32 }
33 list->append(*dimension); 33 list->append(*dimension);
34 } 34 }
35 35
36 CSSValue* rotation = CSSPropertyParserHelpers::consumeAngle(range); 36 CSSValue* rotation = CSSPropertyParserHelpers::consumeAngle(range);
37 if (!rotation) 37 if (!rotation)
38 return nullptr; 38 return nullptr;
39 list->append(*rotation); 39 list->append(*rotation);
40 40
41 return list; 41 return list;
42 } 42 }
43 43
44 } // namespace blink 44 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698