Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2801873006: Use entities in TypeVariableResolutionAnalysis and TypeVariableCodegenAnalysis (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use entities in TypeVariableResolutionAnalysis and TypeVariableCodegenAnalysis This makes this reuseable for kernel based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/8cf8e5f437d163636aecf3ce033a17af3135acad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -23 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 8 chunks +25 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-07 11:16:15 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-10 19:18:25 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-11 07:56:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8cf8e5f437d163636aecf3ce033a17af3135acad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698