Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2801853006: Produce a compile-time error if there's no main method. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Produce a compile-time error if there's no main method. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/ba0e07846f910efc9d7e055c8b91d1204ee47044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M pkg/front_end/lib/src/fasta/fasta.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_kernel.status View 3 chunks +2 lines, -5 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
ahe
3 years, 8 months ago (2017-04-07 11:38:28 UTC) #2
ahe
Ping :-)
3 years, 8 months ago (2017-04-18 12:55:22 UTC) #3
Vyacheslav Egorov (Google)
lgtm
3 years, 8 months ago (2017-04-18 13:00:36 UTC) #4
karlklose
Shouldn't this be a runtime error for using an undefined getter (together with a warning)?
3 years, 8 months ago (2017-04-19 05:45:04 UTC) #5
ahe
Committed patchset #1 (id:1) manually as ba0e07846f910efc9d7e055c8b91d1204ee47044 (presubmit successful).
3 years, 8 months ago (2017-04-19 12:28:17 UTC) #7
ahe
3 years, 8 months ago (2017-04-19 12:30:39 UTC) #8
Message was sent while issue was closed.
On 2017/04/19 05:45:04, karlklose wrote:
> Shouldn't this be a runtime error for using an undefined getter (together with
a
> warning)?

Yes. It should be a runtime error and this is a short-term work around to avoid
crashing the VM. I've filed https://github.com/dart-lang/sdk/issues/29386 to
track getting this handled correctly in Fasta.

Powered by Google App Engine
This is Rietveld 408576698