Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2471)

Unified Diff: chrome/common/extensions/api/webrtc_audio_private.idl

Issue 2801853005: Create a private API for controlling WebRTC's AEC3 (Closed)
Patch Set: After grunell's second round of comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/webrtc_audio_private.idl
diff --git a/chrome/common/extensions/api/webrtc_audio_private.idl b/chrome/common/extensions/api/webrtc_audio_private.idl
index 32afbd48ee9288b4e4fac6c9807775132584a8e7..dbbf0fd17f19826fc0f71c153573fec697146e81 100644
--- a/chrome/common/extensions/api/webrtc_audio_private.idl
+++ b/chrome/common/extensions/api/webrtc_audio_private.idl
@@ -50,6 +50,11 @@ namespace webrtcAudioPrivate {
long? guestProcessId;
};
+ dictionary AudioExperiments {
+ // Enables or disables the new acoustic echo canceller (AEC3) in WebRTC.
+ boolean? enableAec3;
+ };
+
interface Functions {
// Retrieves a list of available audio sink devices.
static void getSinks(GetSinksCallback callback);
@@ -75,6 +80,11 @@ namespace webrtcAudioPrivate {
static void getAssociatedSink(DOMString securityOrigin,
DOMString sourceIdInOrigin,
SinkIdCallback cb);
+
+ // Provides settings to experiments related to WebRTC audio.
+ static void setAudioExperiments(RequestInfo request,
Devlin 2017/04/10 21:34:25 Document the parameters this accepts. Also, probab
Henrik Grunell 2017/04/11 06:49:39 I asked the author to remove the callback that was
hlundin-chromium 2017/04/11 09:19:37 Added documentation.
Devlin 2017/04/11 20:49:37 The main reason is consistency with other APIs and
hlundin-chromium 2017/04/12 05:54:16 Time is not on our side now, so I'll prefer to hol
+ DOMString securityOrigin,
+ AudioExperiments audioExperiments);
};
interface Events {

Powered by Google App Engine
This is Rietveld 408576698