content/common/media/aec_dump_messages.h - Issue 2801853005: Create a private API for controlling WebRTC's AEC3

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/media/aec_dump_messages.h

Issue 2801853005: Create a private API for controlling WebRTC's AEC3 (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/public/browser/render_process_host.h » ('j') | content/public/browser/render_process_host.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for the AEC dump.	5 // IPC messages for the AEC dump.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include "content/common/content_export.h"	8 #include "content/common/content_export.h"

9 #include "ipc/ipc_message_macros.h"	9 #include "ipc/ipc_message_macros.h"

10 #include "ipc/ipc_platform_file.h"	10 #include "ipc/ipc_platform_file.h"

(...skipping 16 matching lines...) Expand all Loading...
27 // Messages sent from the renderer to the browser.	27 // Messages sent from the renderer to the browser.

28	28

29 // Registers a consumer with the browser. The consumer will then get a file	29 // Registers a consumer with the browser. The consumer will then get a file

30 // handle when the dump is enabled.	30 // handle when the dump is enabled.

31 IPC_MESSAGE_CONTROL1(AecDumpMsg_RegisterAecDumpConsumer,	31 IPC_MESSAGE_CONTROL1(AecDumpMsg_RegisterAecDumpConsumer,

32 int /* id */)	32 int /* id */)

33	33

34 // Unregisters a consumer with the browser.	34 // Unregisters a consumer with the browser.

35 IPC_MESSAGE_CONTROL1(AecDumpMsg_UnregisterAecDumpConsumer,	35 IPC_MESSAGE_CONTROL1(AecDumpMsg_UnregisterAecDumpConsumer,

36 int /* id */)	36 int /* id */)

	37

	38 // TODO(hlundin) Move to new file?
	hlundin-chromium 2017/04/06 19:09:08 Should this be moved to another file? If so, which Should this be moved to another file? If so, which file? audio_messages.h? New file? Henrik Grunell 2017/04/10 08:13:28 Keep it in this file, but this file should be rena Show quoted text On 2017/04/06 19:09:08, hlundin-chromium wrote: > Should this be moved to another file? If so, which file? audio_messages.h? New > file? Keep it in this file, but this file should be renamed to audio_processing_messages.h and the AEC dump message filter class to AudioProcessingMessageFilter. I'm fine with doing this in a follow-up CL together with the change in another comment. Update todo and refer to bug. hlundin-chromium 2017/04/10 10:10:16 Done. Show quoted text On 2017/04/10 08:13:28, Henrik Grunell wrote: > On 2017/04/06 19:09:08, hlundin-chromium wrote: > > Should this be moved to another file? If so, which file? audio_messages.h? New > > file? > > Keep it in this file, but this file should be renamed to > audio_processing_messages.h and the AEC dump message filter class to > AudioProcessingMessageFilter. I'm fine with doing this in a follow-up CL > together with the change in another comment. Update todo and refer to bug. Done.
	39 IPC_MESSAGE_CONTROL2(AudioProcessingMsg_EnableAec3,

	40 int /* id */,

	41 bool /* enable */)

OLD	NEW