Create a private API for controlling WebRTC's AEC3

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 2325 matching lines @@
 
 bool RenderProcessHostImpl::StartWebRTCEventLog(
     const base::FilePath& file_path) {
   return webrtc_eventlog_host_.StartWebRTCEventLog(file_path);
 }
 
 bool RenderProcessHostImpl::StopWebRTCEventLog() {
   return webrtc_eventlog_host_.StopWebRTCEventLog();
 }
 
+void RenderProcessHostImpl::SetEchoCanceller3(bool enable) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+  // Piggybacking on AEC dumps.
+  // TODO(hlundin) Consider changing name for aec_dump_consumers_.

[Henrik Grunell, 2017/04/10 08:13:28]

I think this should be done. I'm OK with a follow-up CL. Can you file a bug to
track?

[hlundin-chromium, 2017/04/10 10:10:16]

Done.

+  for (std::vector<int>::iterator it = aec_dump_consumers_.begin();
+       it != aec_dump_consumers_.end(); ++it) {
+    SetEchoCanceller3ForId(enable, *it);

[Henrik Grunell, 2017/04/10 08:13:28]

Just do

Send(new AudioProcessingMsg_EnableAec3(id, enable));

here and remove SetEchoCanceller3ForId().

[hlundin-chromium, 2017/04/10 10:10:16]

Done.

+  }
+}
+
 void RenderProcessHostImpl::SetWebRtcLogMessageCallback(
     base::Callback<void(const std::string&)> callback) {
 #if BUILDFLAG(ENABLE_WEBRTC)
   BrowserMainLoop::GetInstance()->media_stream_manager()->
       RegisterNativeLogCallback(GetID(), callback);
 #endif
 }
 
 void RenderProcessHostImpl::ClearWebRtcLogMessageCallback() {
 #if BUILDFLAG(ENABLE_WEBRTC)
@@ skipping 632 matching lines @@
 }
 
 void RenderProcessHostImpl::RegisterAecDumpConsumerOnUIThread(int id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   aec_dump_consumers_.push_back(id);
 
   if (WebRTCInternals::GetInstance()->IsAudioDebugRecordingsEnabled()) {
     base::FilePath file_with_extensions = GetAecDumpFilePathWithExtensions(
         WebRTCInternals::GetInstance()->GetAudioDebugRecordingsFilePath());
     EnableAecDumpForId(file_with_extensions, id);
   }

[Henrik Grunell, 2017/04/10 08:13:28]

Here, you need to set experiments for a new consumer. So the experiments must be
stored somewhere, either this class or if possible to access the extension API
class (not sure about this) in that class.

Otherwise, a getUserMedia call after being set won't honor the settings.

[hlundin-chromium, 2017/04/10 10:10:16]

Done.

Added a class member to remember the state.

 }
 
 void RenderProcessHostImpl::UnregisterAecDumpConsumerOnUIThread(int id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   for (std::vector<int>::iterator it = aec_dump_consumers_.begin();
        it != aec_dump_consumers_.end(); ++it) {
     if (*it == id) {
       aec_dump_consumers_.erase(it);
       break;
     }
@@ skipping 20 matching lines @@
 
 void RenderProcessHostImpl::SendDisableAecDumpToRenderer() {
   Send(new AecDumpMsg_DisableAecDump());
 }
 
 base::FilePath RenderProcessHostImpl::GetAecDumpFilePathWithExtensions(
     const base::FilePath& file) {
   return file.AddExtension(IntToStringType(base::GetProcId(GetHandle())))
       .AddExtension(kAecDumpFileNameAddition);
 }
+
+void RenderProcessHostImpl::SetEchoCanceller3ForId(bool enable, int id) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+  Send(new AudioProcessingMsg_EnableAec3(id, enable));
+}
 #endif  // BUILDFLAG(ENABLE_WEBRTC)
 
 void RenderProcessHostImpl::GetAudioOutputControllers(
     const GetAudioOutputControllersCallback& callback) const {
   audio_renderer_host()->GetOutputControllers(callback);
 }
 
 void RenderProcessHostImpl::RecomputeAndUpdateWebKitPreferences() {
   // We are updating all widgets including swapped out ones.
   for (auto* widget : widgets_) {
@@ skipping 11 matching lines @@
   LOG(ERROR) << "Terminating render process for bad Mojo message: " << error;
 
   // The ReceivedBadMessage call below will trigger a DumpWithoutCrashing.
   // Capture the error message in a crash key value.
   base::debug::ScopedCrashKey error_key_value("mojo-message-error", error);
   bad_message::ReceivedBadMessage(render_process_id,
                                   bad_message::RPH_MOJO_PROCESS_ERROR);
 }
 
 }  // namespace content