third_party/WebKit/Source/modules/presentation/PresentationReceiver.h - Issue 2801823003: [Presentation API] Change connection to 'connected' if start a presentation with "https://www.googl…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationReceiver.h

Issue 2801823003: [Presentation API] Change connection to 'connected' if start a presentation with "https://www.googl… (Closed)

Patch Set: resolve code review comments from Mark Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/presentation/presentation_dispatcher.cc ('k') | third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationReceiver.h

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h b/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h

index a65e29cd562aaecf2125f64d35def0d0913c9876..45fb364f8e92cbf36ffaa5890308cf057f4169e3 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h

+++ b/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h

@@ -37,9 +37,13 @@ class MODULES_EXPORT PresentationReceiver final

Member<DOMException>>;

public:

- explicit PresentationReceiver(LocalFrame*, WebPresentationClient*);

+ PresentationReceiver(LocalFrame*, WebPresentationClient*);

~PresentationReceiver() = default;

+ // This need to be eagerly created in order to have the receiver associated

imcheng 2017/04/11 02:00:27 nit: Feels like this should be a class-level comme

zhaobin 2017/04/11 02:57:51 Done.

+ // with the client.

+ MODULES_EXPORT static PresentationReceiver* from(Document&);

// PresentationReceiver.idl implementation

ScriptPromise connectionList(ScriptState*);