Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load. (Closed)
Patch Set: aw Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 4442c56315ee22648def0f07bb2ec6383d4a369c..b8e3a02e3e7c3b016fcf57334dd55bdb923c9611 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -877,6 +877,8 @@ class CONTENT_EXPORT WebContentsImpl
JavaScriptDialogsInMainAndSubframes);
FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
IframeBeforeUnloadParentHang);
+ FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
+ BeforeUnloadDialogRequiresGesture);
// So |find_request_manager_| can be accessed for testing.
friend class FindRequestManagerTest;

Powered by Google App Engine
This is Rietveld 408576698