android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java - Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load. (Closed)

Patch Set: aw Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java » ('j') | chrome/browser/lifetime/browser_close_manager_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

index c65fa0404ac37c8075e912b83833bc38663d98cf..1b6f76e707a629a7698accdf45bed320dc3dab2b 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

@@ -14,6 +14,7 @@ import android.support.test.filters.SmallTest;

import org.chromium.android_webview.AwContents;

import org.chromium.android_webview.JsPromptResultReceiver;

import org.chromium.android_webview.JsResultReceiver;

+import org.chromium.android_webview.test.util.AwTestTouchUtils;

import org.chromium.base.test.util.CallbackHelper;

import org.chromium.base.test.util.Feature;

@@ -176,6 +177,8 @@ public class WebViewModalDialogOverrideTest extends AwTestBase {

loadDataSync(awContents, client.getOnPageFinishedHelper(), BEFORE_UNLOAD_URL,

"text/html", false);

enableJavaScriptOnUiThread(awContents);

+ // JavaScript onbeforeunload dialogs require a user gesture.

+ AwTestTouchUtils.simulateTouchCenterOfView(view);

// Don't wait synchronously because we don't leave the page.

int currentCallCount = jsBeforeUnloadHelper.getCallCount();