third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html - Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html

Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load. (Closed)

Patch Set: test fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/lifetime/browser_close_manager_browsertest.cc ('K') | « content/test/data/render_frame_host/beforeunload.html ('k') | third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html b/third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html

index 06a267899aa619c0729391a77589bdf8ea7e0a92..cd582afdaceddb4486239ef1b0cb7f621c9bfa31 100644

--- a/third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html

+++ b/third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html

@@ -6,6 +6,12 @@ window.onload = function ()

testRunner.setShouldStayOnPageAfterHandlingBeforeUnload(true);

testRunner.waitUntilDone();

}

+ // JavaScript onbeforeunload dialogs require a user gesture.

+ if (window.eventSender) {

+ eventSender.mouseMoveTo(5, 5);

+ eventSender.mouseDown();

+ eventSender.mouseUp();

+ }

if (sessionStorage.fail) {

if (window.testRunner)

testRunner.notifyDone();