Only show a beforeunload dialog if a frame has had a user gesture since its load.

chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.content.DialogInterface;
 import android.support.test.filters.MediumTest;
 import android.support.v7.app.AlertDialog;
 import android.util.Log;
 import android.view.View;
 import android.widget.Button;
 import android.widget.CheckBox;
 import android.widget.EditText;
 
 import org.chromium.base.ThreadUtils;
+import org.chromium.base.test.util.CallbackHelper;
 import org.chromium.base.test.util.Feature;
 import org.chromium.base.test.util.RetryOnFailure;
 import org.chromium.base.test.util.UrlUtils;
 import org.chromium.chrome.R;
 import org.chromium.chrome.test.ChromeActivityTestCaseBase;
 import org.chromium.content.browser.test.util.Criteria;
 import org.chromium.content.browser.test.util.CriteriaHelper;
 import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
 import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnEvaluateJavaScriptResultHelper;
+import org.chromium.content_public.browser.GestureStateListener;
 
 import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.TimeoutException;
 
 /**
  * Test suite for displaying and functioning of modal dialogs.
  */
 @RetryOnFailure
 public class ModalDialogTest extends ChromeActivityTestCaseBase<ChromeActivity> {
@@ skipping 124 matching lines @@
         assertTrue("Failed to find prompt view in prompt dialog.", result);
 
         clickOk(jsDialog);
         assertTrue("JavaScript execution should continue after closing prompt.",
                 scriptEvent.waitUntilHasValue());
 
         String resultString = scriptEvent.getJsonResultAndClear();
         assertEquals("Invalid return value.", '"' + promptText + '"', resultString);
     }
 
+    private static class TapGestureStateListener extends GestureStateListener {
+        private CallbackHelper mCallbackHelper = new CallbackHelper();
+
+        public int getCallCount() {
+            return mCallbackHelper.getCallCount();
+        }
+
+        public void waitForTap(int currentCallCount)
+                throws InterruptedException, TimeoutException {
+            mCallbackHelper.waitForCallback(currentCallCount);
+        }
+
+        @Override
+        public void onSingleTap(boolean consumed) {
+            mCallbackHelper.notifyCalled();
+        }
+    }
+
+    /**
+     * Taps on a view and waits for a callback.
+     */
+    private void tapViewAndWait() throws InterruptedException, TimeoutException {
+        final TapGestureStateListener tapGestureStateListener =
+                new TapGestureStateListener();
+        int callCount = tapGestureStateListener.getCallCount();
+        getActivity().getCurrentContentViewCore()
+                .addGestureStateListener(tapGestureStateListener);
+
+        singleClickView(getActivity().getActivityTab().getView());
+        tapGestureStateListener.waitForTap(callCount);
+    }
+
     /**
      * Verifies beforeunload dialogs are shown and they block/allow navigation
      * as appropriate.
      */
     @MediumTest
     @Feature({"Browser", "Main"})
     public void testBeforeUnloadDialog()
             throws InterruptedException, TimeoutException, ExecutionException {
         loadUrl(BEFORE_UNLOAD_URL);
+        // JavaScript onbeforeunload dialogs require a user gesture.
+        tapViewAndWait();
         executeJavaScriptAndWaitForDialog("history.back();");
 
         JavascriptAppModalDialog jsDialog = getCurrentDialog();
         assertNotNull("No dialog showing.", jsDialog);
         checkButtonPresenceVisibilityText(jsDialog, 0, R.string.cancel, "Cancel");
         clickCancel(jsDialog);
 
         assertEquals(BEFORE_UNLOAD_URL, getActivity().getCurrentContentViewCore()
                 .getWebContents().getUrl());
         executeJavaScriptAndWaitForDialog("history.back();");
@@ skipping 10 matching lines @@
         assertEquals(EMPTY_PAGE, getActivity().getCurrentContentViewCore()
                 .getWebContents().getUrl());
     }
 
     /**
      * Verifies that when showing a beforeunload dialogs as a result of a page
      * reload, the correct UI strings are used.
      */
     @MediumTest
     @Feature({"Browser", "Main"})
-    public void testBeforeUnloadOnReloadDialog() throws InterruptedException, ExecutionException {
+    public void testBeforeUnloadOnReloadDialog()
+            throws InterruptedException, TimeoutException, ExecutionException {
         loadUrl(BEFORE_UNLOAD_URL);
+        // JavaScript onbeforeunload dialogs require a user gesture.
+        tapViewAndWait();
         executeJavaScriptAndWaitForDialog("window.location.reload();");
 
         JavascriptAppModalDialog jsDialog = getCurrentDialog();
         assertNotNull("No dialog showing.", jsDialog);
 
         checkButtonPresenceVisibilityText(jsDialog, 0, R.string.cancel, "Cancel");
         checkButtonPresenceVisibilityText(jsDialog, 2, R.string.reload, "Reload");
     }
 
     /**
@@ skipping 178 matching lines @@
                 button.getVisibility());
         assertEquals("'" + readableName + "' button has wrong text",
                 getActivity().getResources().getString(expectedTextResourceId),
                 button.getText().toString());
     }
 
     private TestCallbackHelperContainer getActiveTabTestCallbackHelperContainer() {
         return new TestCallbackHelperContainer(getActivity().getCurrentContentViewCore());
     }
 }