Index: content/renderer/media_recorder/video_track_recorder_unittest.cc |
diff --git a/content/renderer/media_recorder/video_track_recorder_unittest.cc b/content/renderer/media_recorder/video_track_recorder_unittest.cc |
index 360319775afe63019d8a9db8d92754bd9a286c12..4e5e7ea942b843ce42b99a49bc88edf2be16af76 100644 |
--- a/content/renderer/media_recorder/video_track_recorder_unittest.cc |
+++ b/content/renderer/media_recorder/video_track_recorder_unittest.cc |
@@ -47,12 +47,16 @@ const VideoTrackRecorder::CodecId kTrackRecorderTestCodec[] = { |
VideoTrackRecorder::CodecId::VP8, |
VideoTrackRecorder::CodecId::VP9 |
#if BUILDFLAG(RTC_USE_H264) |
+ // This unittest can't enumerate HW codecs due to no render thread created. |
+ // So H264 can't be included on Android because OpenH264 is not supported. |
emircan
2017/04/17 17:24:06
We create a ChildProcess for test on l.134 which s
braveyao
2017/04/17 18:09:27
It fails to enumerate VEA at https://cs.chromium.o
emircan
2017/04/17 18:39:59
I see. This test only exercises the SW encode path
|
, VideoTrackRecorder::CodecId::H264 |
#endif |
}; |
const gfx::Size kTrackRecorderTestSize[] = { |
+#if !defined(OS_ANDROID) |
mcasas
2017/04/17 20:10:39
Use positive ifdefs.
braveyao
2017/04/18 16:15:38
Done.
|
gfx::Size(kVEAEncoderMinResolutionWidth / 2, |
kVEAEncoderMinResolutionHeight / 2), |
mcasas
2017/04/17 20:10:39
Why do you do this? I think it's so that you can f
braveyao
2017/04/18 16:15:38
Done.
You're right. Forgot to remove it as H264 is
|
+#endif |
gfx::Size(kVEAEncoderMinResolutionWidth, kVEAEncoderMinResolutionHeight)}; |
static const int kTrackRecorderTestSizeDiff = 20; |