Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Unified Diff: chrome/browser/resources/settings/a11y_page/a11y_page.html

Issue 2801753003: MD-Settings: Label toggle button in Accessibility section. (Closed)
Patch Set: remove aria-labelledby Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/a11y_page/a11y_page.html
diff --git a/chrome/browser/resources/settings/a11y_page/a11y_page.html b/chrome/browser/resources/settings/a11y_page/a11y_page.html
index cd50d93f0ff60431afc5c94de00c23514dd89fd4..ffd329ff18f58deea07e84cbc15523a549af73e7 100644
--- a/chrome/browser/resources/settings/a11y_page/a11y_page.html
+++ b/chrome/browser/resources/settings/a11y_page/a11y_page.html
@@ -18,15 +18,11 @@
<settings-animated-pages id="pages" current-route="{{currentRoute}}"
section="a11y">
<neon-animatable route-path="default">
- <div class="settings-box first">
- <div id="optionsInMenuLabel" class="start">
- $i18n{optionsInMenuLabel}
- </div>
- <settings-toggle-button id="optionsInMenuToggle"
- pref="{{prefs.settings.a11y.enable_menu}}"
- aria-labelledby="optionsInMenuLabel">
- </settings-toggle-button>
- </div>
+ <settings-toggle-button id="optionsInMenuToggle"
+ class="settings-box"
Dan Beam 2017/04/07 18:55:03 i suppose this could work but we've got a lot of o
+ label="$i18n{optionsInMenuLabel}"
+ pref="{{prefs.settings.a11y.enable_menu}}">
+ </settings-toggle-button>
<div id="subpage-trigger" class="settings-box two-line"
on-tap="onManageAccessibilityFeaturesTap_" actionable>
<div class="start">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698