Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js

Issue 2801723003: [DevTools] Do not reset storage tree items (Closed)
Patch Set: [DevTools] Do not reset storage tree items Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js b/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
index c68aa70b85097948c17aa096a45d0cdf663e53aa..d7a2d2266a37202ba02eb92d2594e26a69cc91b1 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
@@ -233,21 +233,6 @@ Resources.ApplicationPanelSidebar = class extends UI.VBox {
this.databasesListTreeElement.setExpandable(false);
}
- _resetDOMStorage() {
- this._domStorageTreeElements.clear();
- this.localStorageListTreeElement.removeChildren();
- this.sessionStorageListTreeElement.removeChildren();
- }
-
- _resetCookies() {
- this.cookieListTreeElement.removeChildren();
- }
-
- _resetCacheStorage() {
- this.cacheStorageListTreeElement.removeChildren();
- this.cacheStorageListTreeElement.setExpandable(false);
- }
-
_resetAppCache() {
for (var frameId of Object.keys(this._applicationCacheFrameElements))
this._applicationCacheFrameManifestRemoved({data: frameId});
@@ -257,15 +242,7 @@ Resources.ApplicationPanelSidebar = class extends UI.VBox {
_reset() {
this._domains = {};
this._resetWebSQL();
- this._resetDOMStorage();
- this._resetCookies();
- this._resetCacheStorage();
- // No need to this._resetAppCache.
-
- this._panel.resetView();
-
- if (this._sidebarTree.selectedTreeElement)
- this._sidebarTree.selectedTreeElement.deselect();
+ this.cookieListTreeElement.removeChildren();
}
_frameNavigated(event) {
@@ -859,6 +836,7 @@ Resources.ServiceWorkerCacheTreeElement = class extends Resources.StorageCategor
swCacheTreeElement.clear();
this.removeChild(swCacheTreeElement);
this._swCacheTreeElements.remove(swCacheTreeElement);
+ this.setExpandable(this.childCount() > 0);
}
/**
@@ -1130,6 +1108,7 @@ Resources.IndexedDBTreeElement = class extends Resources.StorageCategoryTreeElem
idbDatabaseTreeElement.clear();
this.removeChild(idbDatabaseTreeElement);
this._idbDatabaseTreeElements.remove(idbDatabaseTreeElement);
+ this.setExpandable(this.childCount() > 0);
}
/**

Powered by Google App Engine
This is Rietveld 408576698