Reify implicit casts for FutureOr

pkg/analyzer/test/src/task/strong/checker_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.src.task.strong.checker_test;
 
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import 'strong_test_helper.dart';
 
@@ skipping 903 matching lines @@
 
   test_functionModifiers_async() async {
     await checkFile('''
 import 'dart:async';
 import 'dart:math' show Random;
 
 dynamic x;
 
 foo1() async => x;
 Future foo2() async => x;
-Future<int> foo3() async => x;
+Future<int> foo3() async => /*info:DYNAMIC_CAST*/x;
 Future<int> foo4() async => new Future<int>.value(x);
 Future<int> foo5() async =>
     /*error:RETURN_OF_INVALID_TYPE*/new Future<String>.value(x);
 
 bar1() async { return x; }
 Future bar2() async { return x; }
-Future<int> bar3() async { return x; }
+Future<int> bar3() async { return /*info:DYNAMIC_CAST*/x; }
 Future<int> bar4() async { return new Future<int>.value(x); }
 Future<int> bar5() async {
   return /*error:RETURN_OF_INVALID_TYPE*/new Future<String>.value(x);
 }
 
 int y;
 Future<int> z;
 
 baz() async {
   int a = /*info:DYNAMIC_CAST*/await x;
   int b = await y;
   int c = await z;
   String d = /*error:INVALID_ASSIGNMENT*/await z;
 }
 
 Future<bool> get issue_ddc_264 async {
   await 42;
   if (new Random().nextBool()) {
     return true;
   } else {
     return new Future<bool>.value(false);
   }
 }
 
 
 Future<String> issue_sdk_26404() async {
-  return (1 > 0) ? new Future<String>.value('hello') : "world";
+  return (/*info:DOWN_CAST_COMPOSITE*/(1 > 0) ? new Future<String>.value('hello') : "world");

[vsm, 2017/04/05 15:52:59]

FYI - this is a cast from Object to FutureOr<String> :-(

[Leaf, 2017/04/05 20:47:27]

The fact that the LUB is Object is WAI.  The consensus on the language team was
not to make LUB produce FutureOr.

Treating this as a cast to FutureOr<String> is, I believe, a valid
implementation strategy but is not the only valid strategy.

[vsm, 2017/04/07 22:23:07]

Makes sense.  Yes, it'll work - just unnecessary casts.

 }
 ''');
   }
 
   test_functionModifiers_asyncStar() async {
     await checkFile('''
 import 'dart:async';
 
 dynamic x;
 
@@ skipping 3173 matching lines @@
 class CheckerTest_Driver extends CheckerTest {
   @override
   bool get enableNewAnalysisDriver => true;
 
   @failingTest
   @override
   test_covariantOverride_fields() async {
     await super.test_covariantOverride_fields();
   }
 }