Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc

Issue 2801643003: Use ScopedTaskEnvironment instead of MessageLoop in google_apis unit tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A complete set of unit tests for OAuth2AccessTokenFetcherImpl. 5 // A complete set of unit tests for OAuth2AccessTokenFetcherImpl.
6 6
7 #include "google_apis/gaia/oauth2_access_token_fetcher_impl.h" 7 #include "google_apis/gaia/oauth2_access_token_fetcher_impl.h"
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
11 11
12 #include "base/run_loop.h" 12 #include "base/run_loop.h"
13 #include "base/test/scoped_task_environment.h"
13 #include "base/threading/thread_task_runner_handle.h" 14 #include "base/threading/thread_task_runner_handle.h"
14 #include "build/build_config.h" 15 #include "build/build_config.h"
15 #include "google_apis/gaia/gaia_urls.h" 16 #include "google_apis/gaia/gaia_urls.h"
16 #include "google_apis/gaia/google_service_auth_error.h" 17 #include "google_apis/gaia/google_service_auth_error.h"
17 #include "google_apis/gaia/oauth2_access_token_consumer.h" 18 #include "google_apis/gaia/oauth2_access_token_consumer.h"
18 #include "net/base/net_errors.h" 19 #include "net/base/net_errors.h"
19 #include "net/http/http_status_code.h" 20 #include "net/http/http_status_code.h"
20 #include "net/url_request/test_url_fetcher_factory.h" 21 #include "net/url_request/test_url_fetcher_factory.h"
21 #include "net/url_request/url_fetcher.h" 22 #include "net/url_request/url_fetcher.h"
22 #include "net/url_request/url_fetcher_delegate.h" 23 #include "net/url_request/url_fetcher_delegate.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 118
118 if (!body.empty()) 119 if (!body.empty())
119 url_fetcher->SetResponseString(body); 120 url_fetcher->SetResponseString(body);
120 121
121 EXPECT_CALL(factory_, CreateURLFetcherMock(_, url, _, _)) 122 EXPECT_CALL(factory_, CreateURLFetcherMock(_, url, _, _))
122 .WillOnce(Return(url_fetcher)); 123 .WillOnce(Return(url_fetcher));
123 return url_fetcher; 124 return url_fetcher;
124 } 125 }
125 126
126 protected: 127 protected:
127 base::MessageLoop message_loop_; 128 base::test::ScopedTaskEnvironment scoped_task_environment_;
128 MockUrlFetcherFactory factory_; 129 MockUrlFetcherFactory factory_;
129 MockOAuth2AccessTokenConsumer consumer_; 130 MockOAuth2AccessTokenConsumer consumer_;
130 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; 131 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_;
131 OAuth2AccessTokenFetcherImpl fetcher_; 132 OAuth2AccessTokenFetcherImpl fetcher_;
132 }; 133 };
133 134
134 // These four tests time out, see http://crbug.com/113446. 135 // These four tests time out, see http://crbug.com/113446.
135 TEST_F(OAuth2AccessTokenFetcherImplTest, 136 TEST_F(OAuth2AccessTokenFetcherImplTest,
136 DISABLED_GetAccessTokenRequestFailure) { 137 DISABLED_GetAccessTokenRequestFailure) {
137 TestURLFetcher* url_fetcher = SetupGetAccessToken(false, 0, std::string()); 138 TestURLFetcher* url_fetcher = SetupGetAccessToken(false, 0, std::string());
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 TestURLFetcher url_fetcher(0, GURL("http://www.google.com"), NULL); 268 TestURLFetcher url_fetcher(0, GURL("http://www.google.com"), NULL);
268 url_fetcher.SetResponseString(kValidFailureTokenResponse); 269 url_fetcher.SetResponseString(kValidFailureTokenResponse);
269 270
270 std::string error; 271 std::string error;
271 EXPECT_TRUE( 272 EXPECT_TRUE(
272 OAuth2AccessTokenFetcherImpl::ParseGetAccessTokenFailureResponse( 273 OAuth2AccessTokenFetcherImpl::ParseGetAccessTokenFailureResponse(
273 &url_fetcher, &error)); 274 &url_fetcher, &error));
274 EXPECT_EQ("invalid_grant", error); 275 EXPECT_EQ("invalid_grant", error);
275 } 276 }
276 } 277 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698