chrome/browser/ui/views/harmony/layout_provider_unittest.cc - Issue 2801583002: Use views::style for buttons, bootstrap ash_typography to do so.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/harmony/layout_provider_unittest.cc

Issue 2801583002: Use views::style for buttons, bootstrap ash_typography to do so. (Closed)

Patch Set: placate gn check. new_avatar_button now just avatar_button Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/harmony/layout_provider_unittest.cc

diff --git a/chrome/browser/ui/views/harmony/layout_provider_unittest.cc b/chrome/browser/ui/views/harmony/layout_provider_unittest.cc

index 2e9136af69ea8ba4c7ca8a6ff3b2587f4e230d41..0945b90d2b43123a0dacb07a2228c576956c3c5c 100644

--- a/chrome/browser/ui/views/harmony/layout_provider_unittest.cc

+++ b/chrome/browser/ui/views/harmony/layout_provider_unittest.cc

@@ -279,6 +279,8 @@ TEST(LayoutProviderTest, TypographyLineHeight) {

// buttons have flexibility to configure their own spacing.

EXPECT_EQ(0,

views::style::GetLineHeight(views::style::CONTEXT_BUTTON, kStyle));

+ EXPECT_EQ(

+ 0, views::style::GetLineHeight(views::style::CONTEXT_BUTTON_MD, kStyle));

}

// Ensure that line heights reported in a default bot configuration match the