chrome/browser/ui/views/toolbar/app_menu.cc - Issue 2801583002: Use views::style for buttons, bootstrap ash_typography to do so.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/app_menu.cc

Issue 2801583002: Use views::style for buttons, bootstrap ash_typography to do so. (Closed)

Patch Set: More self review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/app_menu.cc

diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc

index 0309da713eaf67d859522da394a333acbe45e620..bf8be2f0cb603ee60318a597695f10141a752d1b 100644

--- a/chrome/browser/ui/views/toolbar/app_menu.cc

+++ b/chrome/browser/ui/views/toolbar/app_menu.cc

@@ -265,7 +265,7 @@ class InMenuButton : public LabelButton {

set_background(in_menu_background_);

SetBorder(

views::CreateEmptyBorder(0, kHorizontalPadding, 0, kHorizontalPadding));

- SetFontList(MenuConfig::instance().font_list);

+ label()->SetFontList(MenuConfig::instance().font_list);

tapted 2017/04/07 07:49:52 this font_list is a special one for Windows. When

}

void GetAccessibleNodeData(ui::AXNodeData* node_data) override {