Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: third_party/WebKit/Source/core/testing/Internals.h

Issue 2801483002: Add DocumentMarker::MatchStatus enum for text match markers (Closed)
Patch Set: Use string in JavaScript API Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/Internals.h
diff --git a/third_party/WebKit/Source/core/testing/Internals.h b/third_party/WebKit/Source/core/testing/Internals.h
index dd0c161d86d56fa261f54136f2d62e80c231a4cc..5f33dbf866e4454b59dfd7275877c028c03b1f9e 100644
--- a/third_party/WebKit/Source/core/testing/Internals.h
+++ b/third_party/WebKit/Source/core/testing/Internals.h
@@ -33,6 +33,7 @@
#include "bindings/core/v8/ScriptValue.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/css/CSSComputedStyleDeclaration.h"
+#include "core/editing/markers/DocumentMarker.h"
#include "core/page/scrolling/ScrollingCoordinator.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
@@ -183,13 +184,18 @@ class Internals final : public GarbageCollected<Internals>,
const String& markerType,
unsigned index,
ExceptionState&);
- void addTextMatchMarker(const Range*, bool isActive);
+ void addTextMatchMarker(const Range*,
+ const String& matchStatus,
+ ExceptionState&);
void addCompositionMarker(const Range*,
const String& underlineColorValue,
bool thick,
const String& backgroundColorValue,
ExceptionState&);
- void setMarkersActive(Node*, unsigned startOffset, unsigned endOffset, bool);
+ void setMarkersActive(Node*,
+ unsigned startOffset,
+ unsigned endOffset,
+ bool isActive);
Xiaocheng 2017/04/04 21:48:38 Could you also change this one?
void setMarkedTextMatchesAreHighlighted(Document*, bool);
void setFrameViewPosition(Document*, long x, long y, ExceptionState&);

Powered by Google App Engine
This is Rietveld 408576698