Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: milo/appengine/frontend/frontpage.go

Issue 2801463002: Milo: Use custom config caching layer (Closed)
Patch Set: Review: Remove double logging Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/frontend/frontpage.go
diff --git a/milo/appengine/frontend/frontpage.go b/milo/appengine/frontend/frontpage.go
index 249e062dc4b3e1f30db415d60b7b2ca34c2f44d5..2d21b1ac451796249614fca4d12cc56073e896d8 100644
--- a/milo/appengine/frontend/frontpage.go
+++ b/milo/appengine/frontend/frontpage.go
@@ -5,8 +5,6 @@
package frontend
import (
- "net/http"
-
"github.com/luci/luci-go/server/router"
"github.com/luci/luci-go/server/templates"
@@ -31,15 +29,12 @@ func frontpageHandler(c *router.Context) {
return err
}
})
- if err != nil {
- common.ErrorPage(c, http.StatusInternalServerError, err.Error())
- return
- }
fp.CIServices = append(fp.CIServices, *mBuildbucket)
fp.CIServices = append(fp.CIServices, *mBuildbot)
templates.MustRender(c.Context, c.Writer, "pages/frontpage.html", templates.Args{
"frontpage": fp,
+ "error": err.Error(),
})
}
@@ -67,6 +62,7 @@ func frontpageTestData() []common.TestBundle {
},
},
},
+ "error": "couldn't find ice cream",
}
return []common.TestBundle{
{

Powered by Google App Engine
This is Rietveld 408576698