Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: milo/appengine/buildbucket/buckets.go

Issue 2801463002: Milo: Use custom config caching layer (Closed)
Patch Set: Review: Remove double logging Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbot/pubsub_test.go ('k') | milo/appengine/buildbucket/builder.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbucket/buckets.go
diff --git a/milo/appengine/buildbucket/buckets.go b/milo/appengine/buildbucket/buckets.go
index bf73cb3fd0e01533f73bd845751349288b0e084f..5b65cd5bb3a21113ff367e05660625c7b96a16e5 100644
--- a/milo/appengine/buildbucket/buckets.go
+++ b/milo/appengine/buildbucket/buckets.go
@@ -10,17 +10,12 @@ import (
"golang.org/x/net/context"
- "github.com/luci/luci-go/common/logging"
"github.com/luci/luci-go/milo/api/resp"
"github.com/luci/luci-go/milo/appengine/common"
)
func GetAllBuilders(c context.Context) (*resp.CIService, error) {
- settings, err := common.GetSettings(c)
- if err != nil {
- logging.WithError(err).Errorf(c, "could not get settings for buildbucket")
- return nil, err
- }
+ settings := common.GetSettings(c)
bucketSettings := settings.Buildbucket
if bucketSettings == nil {
return nil, errors.New("buildbucket settings missing in config")
« no previous file with comments | « milo/appengine/buildbot/pubsub_test.go ('k') | milo/appengine/buildbucket/builder.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698