milo/appengine/buildbot/pubsub.go - Issue 2801463002: Milo: Use custom config caching layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/buildbot/pubsub.go

Issue 2801463002: Milo: Use custom config caching layer (Closed)

Patch Set: Review: Remove double logging Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/appengine/buildbot/pubsub.go

diff --git a/milo/appengine/buildbot/pubsub.go b/milo/appengine/buildbot/pubsub.go

index db8136fcf05ed27cb3a44521132d272cce719a0a..797e72422a3d5f899c886403ffe37637d79d698f 100644

--- a/milo/appengine/buildbot/pubsub.go

+++ b/milo/appengine/buildbot/pubsub.go

@@ -304,14 +304,7 @@ func pubSubHandlerImpl(c context.Context, r *http.Request) int {

}

internal := true

// Get the name of the subscription on luci-config

- settings, err := common.GetSettings(c)

- if err != nil {

- logging.WithError(err).Errorf(c,

- "Cannot load settings to check subscription name.")

- // This is a configuration error. Tell PubSub to retry until we fix our

- // configs.

- return http.StatusInternalServerError

- }

+ settings := common.GetSettings(c)

switch msg.Subscription {

case settings.Buildbot.PublicSubscription:

internal = false

« no previous file with comments | « luci_config/server/cfgclient/config_test.go ('k') | milo/appengine/buildbot/pubsub_test.go » ('j') | no next file with comments »