Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: luci_config/server/cfgclient/backend/client/client.go

Issue 2801463002: Milo: Use custom config caching layer (Closed)
Patch Set: Review: Remove double logging Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: luci_config/server/cfgclient/backend/client/client.go
diff --git a/luci_config/server/cfgclient/backend/client/client.go b/luci_config/server/cfgclient/backend/client/client.go
index dd8930b0f8197fedc83f4c4693501c21b13a5f2c..57969a7ec52fc9e97a20b51cc52051188e3ceb6f 100644
--- a/luci_config/server/cfgclient/backend/client/client.go
+++ b/luci_config/server/cfgclient/backend/client/client.go
@@ -43,7 +43,7 @@ func (be *Backend) ServiceURL(c context.Context) url.URL { return be.Provider.Ge
// ConfigSetURL implements backend.B.
func (be *Backend) ConfigSetURL(c context.Context, configSet string, p backend.Params) (url.URL, error) {
- u, err := be.getIface(c, p.Authority).GetConfigSetLocation(c, configSet)
+ u, err := be.GetConfigInterface(c, p.Authority).GetConfigSetLocation(c, configSet)
if err != nil || u == nil {
return url.URL{}, err
}
@@ -52,7 +52,7 @@ func (be *Backend) ConfigSetURL(c context.Context, configSet string, p backend.P
// Get implements backend.B.
func (be *Backend) Get(c context.Context, configSet, path string, p backend.Params) (*backend.Item, error) {
- svc := be.getIface(c, p.Authority)
+ svc := be.GetConfigInterface(c, p.Authority)
cfg, err := svc.GetConfig(c, configSet, path, !p.Content)
if err != nil {
@@ -66,7 +66,7 @@ func (be *Backend) Get(c context.Context, configSet, path string, p backend.Para
func (be *Backend) GetAll(c context.Context, t backend.GetAllTarget, path string, p backend.Params) (
[]*backend.Item, error) {
- svc := be.getIface(c, p.Authority)
+ svc := be.GetConfigInterface(c, p.Authority)
var fn func(context.Context, string, bool) ([]config.Config, error)
switch t {
@@ -90,7 +90,7 @@ func (be *Backend) GetAll(c context.Context, t backend.GetAllTarget, path string
return items, nil
}
-func (be *Backend) getIface(c context.Context, a backend.Authority) config.Interface {
+func (be *Backend) GetConfigInterface(c context.Context, a backend.Authority) config.Interface {
return be.Provider.GetConfigClient(c, a)
}
« no previous file with comments | « luci_config/server/cfgclient/backend/backend.go ('k') | luci_config/server/cfgclient/backend/erroring/erroring.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698