MD Settings: mouse movements should focus cr-action-menu items

ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'cr-action-menu',
   extends: 'dialog',
 
   /**
    * List of all options in this action menu.
@@ skipping 14 matching lines @@
    * @private {?Function}
    */
   boundClose_: null,
 
   hostAttributes: {
     tabindex: 0,
   },
 
   listeners: {
     'keydown': 'onKeyDown_',
+    'mouseover': 'onMouseover_',
     'tap': 'onTap_',
   },
 
   /** override */
   attached: function() {
     this.options_ = this.querySelectorAll('.dropdown-item');
   },
 
   /** override */
   detached: function() {
@@ skipping 21 matching lines @@
    * @param {!KeyboardEvent} e
    * @private
    */
   onKeyDown_: function(e) {
     if (e.key == 'Tab' || e.key == 'Escape') {
       this.close();
       e.preventDefault();
       return;
     }
 
+    listenOnce(this, 'mousemove', this.onMouseover_.bind(this));

[dpapad, 2017/04/06 00:06:02]

We are leaking mousemove listeners. When the user presses for example down,
down, down, we are registering 3 of them, but none of them has fired yet. When
the user finally moves their mouse, instead of getting one invocation, we get 3
of them. We need to only add a listener if we haven't added one already.

[Dan Beam, 2017/04/06 00:08:35]

sure, that makes sense

[scottchen, 2017/04/06 00:44:33]

Done.

+
     if (e.key !== 'ArrowDown' && e.key !== 'ArrowUp')
       return;
 
     var nextOption = this.getNextOption_(e.key == 'ArrowDown' ? 1 : -1);
     if (nextOption)
       nextOption.focus();
 
     e.preventDefault();
   },
 
   /**
+   * @param {!MouseEvent} e
+   * @private
+   */
+  onMouseover_: function(e) {
+    // TODO(scottchen): Using "focus" to determine selected item might mess
+    // with screen readers in some edge cases.
+    var target = e.path[0];
+    for (var i = 0; this != target; target = e.path[i++]) {

[Dan Beam, 2017/04/05 23:42:30]

nit:

var i = 0;
for (var target; this != target; target = e.path[i++]) {
  ...
}

[scottchen, 2017/04/06 00:44:33]

I changed it to a do-while for readability.

+      if (target.classList && target.classList.contains('dropdown-item')) {
+        target.focus();
+        return;
+      }
+    };
+
+    // The user moved the mouse off the options. Reset focus to the dialog.
+    this.focus();
+  },
+
+  /**
    * @param {number} step -1 for getting previous option (up), 1 for getting
    *     next option (down).
    * @return {?Element} The next focusable option, taking into account
    *     disabled/hidden attributes, or null if no focusable option exists.
    * @private
    */
   getNextOption_: function(step) {
     // Using a counter to ensure no infinite loop occurs if all elements are
     // hidden/disabled.
     var counter = 0;
@@ skipping 54 matching lines @@
     // Attempt to show the menu starting from the top of the rectangle and
     // extending downwards. If that does not fit within the window, fallback to
     // starting from the bottom and extending upwards.
     var top = rect.top + this.offsetHeight <= window.innerHeight ? rect.top :
                                                                    rect.bottom -
             this.offsetHeight - Math.max(rect.bottom - window.innerHeight, 0);
 
     this.style.top = top + 'px';
   },
 });