[DevTools] Listen to mousedown in SoftContextMenu once

third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js

 /*
  * Copyright (C) 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 32 matching lines @@
    * @param {!AnchorBox} anchorBox
    */
   show(document, anchorBox) {
     if (!this._items.length)
       return;
 
     this._document = document;
 
     this._glassPane = new UI.GlassPane();
     this._glassPane.setBlockPointerEvents(!this._parentMenu);
-    this._glassPane.setSetOutsideClickCallback(event => {

[lushnikov, 2017/04/07 22:25:40]

can we fix the setSetOutsideClickCallback name?

[dgozman, 2017/04/07 22:30:32]

Yeah, in a separate patch?

-      this._discardMenu(true, event);
-      event.consume();

[lushnikov, 2017/04/07 22:25:40]

why does the bug happen in the first place? As far as I see on a video in the
bug, the click doesn't happen outside.

[dgozman, 2017/04/07 22:30:32]

This is because we have two nested menus, and click in one menu happens outside
of the other menu.

-    });
     this._glassPane.registerRequiredCSS('ui/softContextMenu.css');
     this._glassPane.setContentAnchorBox(anchorBox);
     this._glassPane.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent);
     this._glassPane.setMarginBehavior(UI.GlassPane.MarginBehavior.NoMargin);
     this._glassPane.setAnchorBehavior(
         this._parentMenu ? UI.GlassPane.AnchorBehavior.PreferRight : UI.GlassPane.AnchorBehavior.PreferBottom);
 
     this._contextMenuElement = this._glassPane.contentElement.createChild('div', 'soft-context-menu');
     this._contextMenuElement.tabIndex = 0;
     this._contextMenuElement.addEventListener('mouseup', e => e.consume(), false);
     this._contextMenuElement.addEventListener('keydown', this._menuKeyDown.bind(this), false);
 
     for (var i = 0; i < this._items.length; ++i)
       this._contextMenuElement.appendChild(this._createMenuItem(this._items[i]));
 
     this._glassPane.show(document);
     this._focus();
+
+    if (!this._parentMenu) {
+      this._onBodyMouseDown = event => this._discardMenu(true, event);
+      this._document.body.addEventListener('mousedown', this._onBodyMouseDown, false);
+    }
   }
 
   discard() {
     this._discardMenu(true);
   }
 
   _createMenuItem(item) {
     if (item.type === 'separator')
       return this._createSeparator();
 
@@ skipping 239 matching lines @@
     if (event)
       event.consume(true);
   }
 
   _discardSubMenus() {
     if (this._subMenu)
       this._subMenu._discardSubMenus();
     if (this._glassPane) {
       this._glassPane.hide();
       delete this._glassPane;
+      if (this._onBodyMouseDown) {
+        this._document.body.removeEventListener('mousedown', this._onBodyMouseDown, false);
+        delete this._onBodyMouseDown;
+      }
     }
     if (this._parentMenu)
       delete this._parentMenu._subMenu;
   }
 };