[CrOS Tether] Fill out the Initializer class. Tether will now initialize fully once the flag is ena…

chromeos/components/tether/initializer.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_COMPONENTS_TETHER_INITIALIZER_H_
 #define CHROMEOS_COMPONENTS_TETHER_INITIALIZER_H_
 
+#include <memory>
+
 #include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
+#include "components/signin/core/browser/profile_oauth2_token_service.h"
+#include "device/bluetooth/bluetooth_adapter.h"
+#include "device/bluetooth/bluetooth_advertisement.h"
+
+class PrefService;
 
 namespace cryptauth {
 class CryptAuthService;
+class RemoteBeaconSeedFetcher;
 }
 
 namespace chromeos {
 
 namespace tether {
 
+class ActiveHost;
+class ActiveHostNetworkStateUpdater;
+class BleConnectionManager;
+class DeviceIdTetherNetworkGuidMap;
+class HostScanner;
+class HostScanDevicePrioritizer;
+class LocalDeviceDataProvider;
+class NotificationPresenter;
+class TetherConnector;
+class TetherHostFetcher;
+class WifiHotspotConnector;
+
 // Initializes the Tether Chrome OS component.
-// TODO(khorimoto): Implement.
-class Initializer {
+class Initializer : public OAuth2TokenService::Observer {
  public:
-  static void Initialize(cryptauth::CryptAuthService* cryptauth_service);
+  static void Initialize(
+      cryptauth::CryptAuthService* cryptauth_service,
+      std::unique_ptr<NotificationPresenter> notification_presenter,
+      PrefService* pref_service,
+      ProfileOAuth2TokenService* token_service);

[stevenjb, 2017/04/10 20:26:59]

As mentioned before, it is important to pass NHS and MC (and any other global
singletons) to this class explicitly to make the lifetime requirements clear.

Also, having an 'Initialize' method on an 'Initialize' class is just mean. Maybe
rename this 'InitSingleton'? (Or rename this class... I know it's namespaced and
all, but for searching I am personally a fan of more descriptive class names,
e.g. tether::TetherController).

[Kyle Horimoto, 2017/04/11 01:40:40]

Done.

 
  private:
   static Initializer* instance_;
 
-  explicit Initializer(cryptauth::CryptAuthService* cryptauth_service);
-  ~Initializer();
+  Initializer(cryptauth::CryptAuthService* cryptauth_service,
+              std::unique_ptr<NotificationPresenter> notification_presenter,
+              PrefService* pref_service,
+              ProfileOAuth2TokenService* token_service);
+  ~Initializer() override;
+
+  // OAuth2TokenService::Observer:
+  void OnRefreshTokensLoaded() override;
+
+  void OnBluetoothAdapterFetched(
+      scoped_refptr<device::BluetoothAdapter> adapter);
+
+  void IntervalSuccessCallback();
+  void IntervalErrorCallback(device::BluetoothAdvertisement::ErrorCode status);
 
   cryptauth::CryptAuthService* cryptauth_service_;
+  std::unique_ptr<NotificationPresenter> notification_presenter_;
+  PrefService* pref_service_;
+  ProfileOAuth2TokenService* token_service_;
+
+  std::unique_ptr<TetherHostFetcher> tether_host_fetcher_;
+  std::unique_ptr<LocalDeviceDataProvider> local_device_data_provider_;
+  std::unique_ptr<cryptauth::RemoteBeaconSeedFetcher>
+      remote_beacon_seed_fetcher_;
+  std::unique_ptr<BleConnectionManager> ble_connection_manager_;
+  std::unique_ptr<HostScanDevicePrioritizer> host_scan_device_prioritizer_;
+  std::unique_ptr<WifiHotspotConnector> wifi_hotspot_connector_;
+  std::unique_ptr<ActiveHost> active_host_;
+  std::unique_ptr<ActiveHostNetworkStateUpdater>
+      active_host_network_state_updater_;
+  std::unique_ptr<DeviceIdTetherNetworkGuidMap>
+      device_id_tether_network_guid_map_;
+  std::unique_ptr<TetherConnector> tether_connector_;
+  std::unique_ptr<HostScanner> host_scanner_;
+
+  base::WeakPtrFactory<Initializer> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Initializer);
 };
 
 }  // namespace tether
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_COMPONENTS_TETHER_INITIALIZER_H_