Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2801283002: Wrap VariableDeclarations in Blocks as specified by Kernel. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Wrap VariableDeclarations in Blocks as specified by Kernel. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/cf6b2736ec0d1d75366331ee58e9a2e357bed49d

Patch Set 1 #

Patch Set 2 : Update strong.status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000069.dart.direct.expect View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 2 chunks +0 lines, -4 lines 0 comments Download
M tests/language/language_kernel.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 8 months ago (2017-04-07 12:50:50 UTC) #2
Paul Berry
lgtm
3 years, 8 months ago (2017-04-07 15:33:08 UTC) #3
ahe
3 years, 8 months ago (2017-04-20 07:31:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cf6b2736ec0d1d75366331ee58e9a2e357bed49d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698