Issue 280123003: Rollback option put behind the flag.

Issue 280123003: Rollback option put behind the flag. (Closed)

Created:
6 years, 7 months ago by merkulova

Modified:
6 years, 7 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rollback option put behind the flag. Recreation of issue 267393011. BUG=368860 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269851

Patch Set 2 : Nit #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -31 lines)			Patch
M	chrome/browser/chromeos/login/reset_browsertest.cc	View	1	4 chunks	+42 lines, -29 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	chromeos/chromeos_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/chromeos_switches.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm https://codereview.chromium.org/280123003/diff/1/chrome/browser/chromeos/login/reset_browsertest.cc File chrome/browser/chromeos/login/reset_browsertest.cc (right): https://codereview.chromium.org/280123003/diff/1/chrome/browser/chromeos/login/reset_browsertest.cc#newcode109 chrome/browser/chromeos/login/reset_browsertest.cc:109: switches::kEnableRollbackOption)) nit: {}

6 years, 7 months ago (2014-05-12 11:41:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/280123003/10005

6 years, 7 months ago (2014-05-12 11:42:38 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-12 15:06:37 UTC) #5

Message was sent while issue was closed.

Change committed as 269851

Expand Messages | Collapse Messages