Source/core/rendering/RenderTheme.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTheme.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase needed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderTheme.cpp

diff --git a/Source/core/rendering/RenderTheme.cpp b/Source/core/rendering/RenderTheme.cpp

index a050bc43fcc942bb38424b9dd2d4d83aa6b3878c..c50fc43dfdd5a1b2c7ecd79ae953dcca836c4db9 100644

--- a/Source/core/rendering/RenderTheme.cpp

+++ b/Source/core/rendering/RenderTheme.cpp

@@ -883,7 +883,7 @@ void RenderTheme::paintSliderTicks(RenderObject* o, const PaintInfo& paintInfo,

tickRegionSideMargin = trackBounds.y() + (thumbSize.width() - tickSize.width() * zoomFactor) / 2.0;

tickRegionWidth = trackBounds.height() - thumbSize.width();

}

- RefPtr<HTMLCollection> options = dataList->options();

+ RefPtrWillBeRawPtr<HTMLCollection> options = dataList->options();

GraphicsContextStateSaver stateSaver(*paintInfo.context);

paintInfo.context->setFillColor(o->resolveColor(CSSPropertyColor));

for (unsigned i = 0; Element* element = options->item(i); i++) {

« Source/core/html/HTMLAllCollection.cpp ('K') | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/svg/SVGSVGElement.h » ('j') | Source/web/WebNodeList.cpp » ('J')