Source/core/dom/SelectorQuery.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/SelectorQuery.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase needed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/SelectorQuery.cpp

diff --git a/Source/core/dom/SelectorQuery.cpp b/Source/core/dom/SelectorQuery.cpp

index fa403dab692e70ce2cf3be7ddaa8910198505053..e1911102ade42c69a685fd3dee684428cd4b178d 100644

--- a/Source/core/dom/SelectorQuery.cpp

+++ b/Source/core/dom/SelectorQuery.cpp

@@ -134,7 +134,7 @@ bool SelectorDataList::matches(Element& targetElement) const

return false;

}

-PassRefPtr<NodeList> SelectorDataList::queryAll(ContainerNode& rootNode) const

+PassRefPtrWillBeRawPtr<NodeList> SelectorDataList::queryAll(ContainerNode& rootNode) const

{

Vector<RefPtr<Node> > result;

execute<AllElementsSelectorQueryTrait>(rootNode, result);

@@ -475,7 +475,7 @@ bool SelectorQuery::matches(Element& element) const

return m_selectors.matches(element);

}

-PassRefPtr<NodeList> SelectorQuery::queryAll(ContainerNode& rootNode) const

+PassRefPtrWillBeRawPtr<NodeList> SelectorQuery::queryAll(ContainerNode& rootNode) const

{

return m_selectors.queryAll(rootNode);

}

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/SelectorQuery.h ('k') | Source/core/dom/StaticNodeList.h » ('j') | Source/core/html/CollectionIndexCache.h » ('J')