Source/core/html/forms/ColorInputType.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/ColorInputType.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pre-emptively GC a long runnning test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/ColorInputType.cpp

diff --git a/Source/core/html/forms/ColorInputType.cpp b/Source/core/html/forms/ColorInputType.cpp

index 08151e1504efaa4cd221ffb050f9cff4e85b5a0f..4bcf8c7983e605cda941f97072b11eef76be8770 100644

--- a/Source/core/html/forms/ColorInputType.cpp

+++ b/Source/core/html/forms/ColorInputType.cpp

@@ -235,7 +235,7 @@ Vector<ColorSuggestion> ColorInputType::suggestions() const

Vector<ColorSuggestion> suggestions;

HTMLDataListElement* dataList = element().dataList();

if (dataList) {

- RefPtr<HTMLCollection> options = dataList->options();

+ RefPtrWillBeRawPtr<HTMLCollection> options = dataList->options();

for (unsigned i = 0; HTMLOptionElement* option = toHTMLOptionElement(options->item(i)); i++) {

if (!element().isValidValue(option->value()))

continue;

« Source/core/html/CollectionIndexCache.h ('K') | « Source/core/html/RadioNodeList.cpp ('k') | Source/core/html/forms/RangeInputType.cpp » ('j') | Source/web/WebFormElement.cpp » ('J')