Source/core/html/HTMLTableRowsCollection.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTableRowsCollection.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pre-emptively GC a long runnning test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/CollectionIndexCache.h ('K') | « Source/core/html/HTMLTableRowsCollection.h ('k') | Source/core/html/HTMLTableSectionElement.h » ('j') | Source/web/WebFormElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTableRowsCollection.cpp

diff --git a/Source/core/html/HTMLTableRowsCollection.cpp b/Source/core/html/HTMLTableRowsCollection.cpp

index b12d821c800570a45d02b16515d366e77ec9c709..fe0316c535649e2d84fd1bab6d38351d4374b872 100644

--- a/Source/core/html/HTMLTableRowsCollection.cpp

+++ b/Source/core/html/HTMLTableRowsCollection.cpp

@@ -143,9 +143,9 @@ HTMLTableRowsCollection::HTMLTableRowsCollection(ContainerNode& table)

ASSERT(isHTMLTableElement(table));

}

-PassRefPtr<HTMLTableRowsCollection> HTMLTableRowsCollection::create(ContainerNode& table, CollectionType)

+PassRefPtrWillBeRawPtr<HTMLTableRowsCollection> HTMLTableRowsCollection::create(ContainerNode& table, CollectionType)

{

- return adoptRef(new HTMLTableRowsCollection(table));

+ return adoptRefWillBeNoop(new HTMLTableRowsCollection(table));

}

Element* HTMLTableRowsCollection::virtualItemAfter(Element* previous) const

« Source/core/html/CollectionIndexCache.h ('K') | « Source/core/html/HTMLTableRowsCollection.h ('k') | Source/core/html/HTMLTableSectionElement.h » ('j') | Source/web/WebFormElement.cpp » ('J')