Source/core/html/HTMLNameCollection.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLNameCollection.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pre-emptively GC a long runnning test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLNameCollection.cpp

diff --git a/Source/core/html/HTMLNameCollection.cpp b/Source/core/html/HTMLNameCollection.cpp

index 48def4be81fbe8edbf79dad1c3432ba73485ae8e..99bf5362dfe71b2a6f995b221c720b177bea1b8c 100644

--- a/Source/core/html/HTMLNameCollection.cpp

+++ b/Source/core/html/HTMLNameCollection.cpp

@@ -42,10 +42,11 @@ HTMLNameCollection::HTMLNameCollection(ContainerNode& document, CollectionType t

HTMLNameCollection::~HTMLNameCollection()

{

- ASSERT(ownerNode().isDocumentNode());

ASSERT(type() == WindowNamedItems || type() == DocumentNamedItems);

+#if !ENABLE(OILPAN)

+ ASSERT(ownerNode().isDocumentNode());

ownerNode().nodeLists()->removeCache(this, type(), m_name);

+#endif

}

Element* HTMLNameCollection::virtualItemAfter(Element* previous) const

« Source/core/html/CollectionIndexCache.h ('K') | « Source/core/html/HTMLNameCollection.h ('k') | Source/core/html/HTMLObjectElement.cpp » ('j') | Source/web/WebFormElement.cpp » ('J')