Source/core/html/HTMLFormElement.h - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pre-emptively GC a long runnning test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/CollectionIndexCache.h ('K') | « Source/core/html/HTMLFormControlsCollection.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | Source/web/WebFormElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormElement.h

diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h

index 743997f2ce8264d858334a35268cef1071bca284..727be3dfff99f9018b146a327e54af3a2a7ccd57 100644

--- a/Source/core/html/HTMLFormElement.h

+++ b/Source/core/html/HTMLFormElement.h

@@ -51,8 +51,8 @@ public:

virtual ~HTMLFormElement();

virtual void trace(Visitor*) OVERRIDE;

- PassRefPtr<HTMLCollection> elements();

- void getNamedElements(const AtomicString&, Vector<RefPtr<Element> >&);

+ PassRefPtrWillBeRawPtr<HTMLCollection> elements();

+ void getNamedElements(const AtomicString&, WillBeHeapVector<RefPtrWillBeMember<Element> >&);

unsigned length() const;

Element* item(unsigned index);

@@ -114,7 +114,7 @@ public:

const FormAssociatedElement::List& associatedElements() const;

const Vector<HTMLImageElement*>& imageElements();

- void anonymousNamedGetter(const AtomicString& name, bool&, RefPtr<RadioNodeList>&, bool&, RefPtr<Element>&);

+ void anonymousNamedGetter(const AtomicString& name, bool&, RefPtrWillBeRawPtr<RadioNodeList>&, bool&, RefPtr<Element>&);

private:

explicit HTMLFormElement(Document&);

« Source/core/html/CollectionIndexCache.h ('K') | « Source/core/html/HTMLFormControlsCollection.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | Source/web/WebFormElement.cpp » ('J')