Source/core/dom/Element.h - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.h

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pre-emptively GC a long runnning test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.h

diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h

index 6142d6ad49b0b3c34418b097c8d783dbd552e1ef..c248984e2a833b89b21d1287a07ac05609046949 100644

--- a/Source/core/dom/Element.h

+++ b/Source/core/dom/Element.h

@@ -544,7 +544,7 @@ protected:

// moved to RenderObject because some focusable nodes don't have renderers,

// e.g., HTMLOptionElement.

virtual bool rendererIsFocusable() const;

- PassRefPtr<HTMLCollection> ensureCachedHTMLCollection(CollectionType);

+ PassRefPtrWillBeRawPtr<HTMLCollection> ensureCachedHTMLCollection(CollectionType);

HTMLCollection* cachedHTMLCollection(CollectionType);

// classAttributeChanged() exists to share code between

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/Document.cpp ('k') | Source/core/dom/Element.cpp » ('j') | Source/core/dom/NodeRareData.h » ('J')