Source/bindings/v8/custom/V8WindowCustom.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8WindowCustom.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pre-emptively GC a long runnning test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8WindowCustom.cpp

diff --git a/Source/bindings/v8/custom/V8WindowCustom.cpp b/Source/bindings/v8/custom/V8WindowCustom.cpp

index b0dfa0e266c4e0d337f1ace044915335a5f4c4b5..fd089a8d5f2982b89e071f3f956a4a8969cd4916 100644

--- a/Source/bindings/v8/custom/V8WindowCustom.cpp

+++ b/Source/bindings/v8/custom/V8WindowCustom.cpp

@@ -415,7 +415,7 @@ void V8Window::namedPropertyGetterCustom(v8::Local<v8::String> name, const v8::P

if (doc && doc->isHTMLDocument()) {

if (toHTMLDocument(doc)->hasNamedItem(propName) || doc->hasElementWithId(propName.impl())) {

- RefPtr<HTMLCollection> items = doc->windowNamedItems(propName);

+ RefPtrWillBeRawPtr<HTMLCollection> items = doc->windowNamedItems(propName);

if (!items->isEmpty()) {

if (items->hasExactlyOneItem()) {

v8SetReturnValueFast(info, items->item(0), window);

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp ('k') | Source/core/dom/ChildListMutationScope.cpp » ('j') | Source/core/dom/Document.h » ('J')