Source/web/WebPageSerializer.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPageSerializer.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPageSerializer.cpp

diff --git a/Source/web/WebPageSerializer.cpp b/Source/web/WebPageSerializer.cpp

index 2c1f37905ad5f1e1519408f8d0a5ecd0d19df3b9..2f1a501f4b88c3212d54352ef4791693ed350ae5 100644

--- a/Source/web/WebPageSerializer.cpp

+++ b/Source/web/WebPageSerializer.cpp

@@ -139,7 +139,7 @@ void retrieveResourcesForFrame(LocalFrame* frame,

frameURLs->append(frameURL);

// Now get the resources associated with each node of the document.

- RefPtr<HTMLCollection> allElements = frame->document()->all();

+ RefPtrWillBeRawPtr<HTMLCollection> allElements = frame->document()->all();

for (unsigned i = 0; i < allElements->length(); ++i) {

Element* element = allElements->item(i);

retrieveResourcesForElement(element,

« no previous file with comments | « Source/web/WebNodeList.cpp ('k') | Source/web/WebPageSerializerImpl.cpp » ('j') | no next file with comments »